Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10623 Add missing case type translations #2129

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

oliver-scott
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/VIH-10623

Change description

Adds some case type translations that were missing

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oliver-scott oliver-scott marked this pull request as ready for review April 16, 2024 15:23
@oliver-scott oliver-scott requested review from a team as code owners April 16, 2024 15:23
Copy link
Contributor

@shaed-parkar shaed-parkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a list of all case types? Or maybe create a script to pull all values from Bookings API and check for translations. This issue pops up quite often

@oliver-scott
Copy link
Contributor Author

oliver-scott commented Apr 17, 2024

Do we have a list of all case types? Or maybe create a script to pull all values from Bookings API and check for translations. This issue pops up quite often

yes that's a good shout, maybe we can have a separate ticket to check all case types. Hopefully this PR will cover at least a good chunk of them, as this issue arose from a specific change where case types were renamed

@oliver-scott oliver-scott merged commit d858061 into master Apr 17, 2024
8 checks passed
@oliver-scott oliver-scott deleted the bug/VIH-10623-missing-translation branch April 17, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants