Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10640 - pm waiting room page unable to auto update and throwing an unexpected error when edit last minute party during hearing #2140

Merged
merged 4 commits into from
May 10, 2024
Merged

VIH-10640 - pm waiting room page unable to auto update and throwing an unexpected error when edit last minute party during hearing #2140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48f915d
removed redundant check
marcogagliardi May 9, 2024
ae96ab2
removed redundant check
marcogagliardi May 9, 2024
ef0523b
Merge branch 'master' into VIH-10640---PM-waiting-room-page-unable-to…
marcogagliardi May 10, 2024
f586375
Update hearing.spec.ts
marcogagliardi May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions VideoWeb/VideoWeb.UnitTests/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@
},
"BookingsApi.Client": {
"type": "Transitive",
"resolved": "1.51.12",
"contentHash": "UXzOXlrW/KJ+iN9yMT1xqIyO35cRa1FBR8ph8DNRgd7dR8OjYRi1/GOiNIDIz4s+h21mfeJteaO/PDGG0reMLg==",
"resolved": "2.0.4",
"contentHash": "FAWFvN92KaIvX+1+8jXp+w69mlrTEguctYrIzLAyw8szQnbmdA9Fo3/dbacd57ACl0desyToxBHqPPpoTzGlsA==",
"dependencies": {
"Microsoft.AspNetCore.Mvc.Core": "2.2.5"
}
Expand Down Expand Up @@ -1976,7 +1976,7 @@
"dependencies": {
"AspNetCore.HealthChecks.Redis": "[6.0.4, )",
"AspNetCore.HealthChecks.Uris": "[6.0.3, )",
"BookingsApi.Client": "[1.51.12, )",
"BookingsApi.Client": "[2.0.4, )",
"Castle.Core": "[5.1.1, )",
"FluentValidation.AspNetCore": "[10.4.0, )",
"MicroElements.Swashbuckle.FluentValidation": "[5.7.0, )",
Expand Down Expand Up @@ -2008,7 +2008,7 @@
"videoweb.common": {
"type": "Project",
"dependencies": {
"BookingsApi.Client": "[1.51.12, )",
"BookingsApi.Client": "[2.0.4, )",
"LaunchDarkly.ServerSdk": "[7.0.0, )",
"Microsoft.ApplicationInsights": "[2.16.0, )",
"Microsoft.ApplicationInsights.AspNetCore": "[2.16.0, )",
Expand Down
5 changes: 0 additions & 5 deletions VideoWeb/VideoWeb/ClientApp/src/app/shared/models/hearing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ import { ConferenceStatus, ParticipantResponseVho, Role } from 'src/app/services
describe('Hearing', () => {
const testData = new ConferenceTestData();

it('should throw an error if passing an invlid type', () => {
const c = testData.getConferenceFuture();
expect(() => new Hearing(c)).toThrowError();
});

it('should map hearing info', () => {
const c = testData.getConferenceDetailFuture();
const hearing = new Hearing(c);
Expand Down
7 changes: 0 additions & 7 deletions VideoWeb/VideoWeb/ClientApp/src/app/shared/models/hearing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,6 @@ export class Hearing extends HearingBase {

constructor(conference: ConferenceResponseVho) {
super();
const isVhResponse = conference instanceof ConferenceResponseVho;
const isParticipantResponse = conference instanceof ConferenceResponse;

if (!(isVhResponse || isParticipantResponse)) {
throw new Error('Object not a ConferenceResponse or ConferenceResponseVHO');
}

this.conference = conference;
if (conference.participants) {
this._participants = this.conference.participants.map(p => new Participant(p));
Expand Down
8 changes: 4 additions & 4 deletions VideoWeb/VideoWeb/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
},
"BookingsApi.Client": {
"type": "Direct",
"requested": "[1.51.12, )",
"resolved": "1.51.12",
"contentHash": "UXzOXlrW/KJ+iN9yMT1xqIyO35cRa1FBR8ph8DNRgd7dR8OjYRi1/GOiNIDIz4s+h21mfeJteaO/PDGG0reMLg==",
"requested": "[2.0.4, )",
"resolved": "2.0.4",
"contentHash": "FAWFvN92KaIvX+1+8jXp+w69mlrTEguctYrIzLAyw8szQnbmdA9Fo3/dbacd57ACl0desyToxBHqPPpoTzGlsA==",
"dependencies": {
"Microsoft.AspNetCore.Mvc.Core": "2.2.5"
}
Expand Down Expand Up @@ -1796,7 +1796,7 @@
"videoweb.common": {
"type": "Project",
"dependencies": {
"BookingsApi.Client": "[1.51.12, )",
"BookingsApi.Client": "[2.0.4, )",
"LaunchDarkly.ServerSdk": "[7.0.0, )",
"Microsoft.ApplicationInsights": "[2.16.0, )",
"Microsoft.ApplicationInsights.AspNetCore": "[2.16.0, )",
Expand Down
Loading