Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-10946 enable audio only toggle in the hearing room #2259

Merged
merged 10 commits into from
Oct 24, 2024
Merged

VIH-10946 enable audio only toggle in the hearing room #2259

merged 10 commits into from
Oct 24, 2024

Conversation

shaed-parkar
Copy link
Contributor

@shaed-parkar shaed-parkar commented Oct 8, 2024 •
edited
Loading

Jira link

VIH-10946

Change description

simplify the device stream management and enable audio only toggle in the hearing room

@shaed-parkar shaed-parkar requested review from a team as code owners October 8, 2024 14:08
@shaed-parkar shaed-parkar force-pushed the feature/VIH-10946_toggle_audio_only_in_hearing branch 3 times, most recently from bb5d4f9 to e8527b4 Compare October 9, 2024 13:23
@shaed-parkar shaed-parkar force-pushed the feature/VIH-10946_toggle_audio_only_in_hearing branch 4 times, most recently from 7433d9c to 0b64a52 Compare October 14, 2024 16:51
@shaed-parkar shaed-parkar force-pushed the feature/VIH-10946_toggle_audio_only_in_hearing branch from 0b64a52 to ccd1fa6 Compare October 18, 2024 16:27
@shaed-parkar shaed-parkar force-pushed the feature/VIH-10946_toggle_audio_only_in_hearing branch from ccd1fa6 to b4b5f75 Compare October 22, 2024 07:54
Shaed Parkar added 4 commits October 22, 2024 10:04
do not start heartbeat if call_type is test_call
63aa1ee
request streams and clean up after self test
61ead73
Merge remote-tracking branch 'origin/master' into feature/VIH-10946_t…
b79185a 
…oggle_audio_only_in_hearing
update puppeteer
71c2e9f 
ignore sonar rule typescript:S2933. readonly members from the ctor is not a style we are adopting in TS
@shaed-parkar shaed-parkar requested a review from a team as a code owner October 23, 2024 19:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
82.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@shaed-parkar shaed-parkar merged commit b1b74a6 into master Oct 24, 2024
8 checks passed
@shaed-parkar shaed-parkar deleted the feature/VIH-10946_toggle_audio_only_in_hearing branch October 24, 2024 11:55
shaed-parkar added a commit that referenced this pull request Oct 24, 2024
@shaed-parkar
VIH-10946 enable audio only toggle in the hearing room (#2259)
745af67 
* VIH-10946 simplify the device stream management and enable audio only toggle in the hearing room
* update puppeteer
* ignore sonar rule typescript:S2933. readonly members from the ctor is not a style we are adopting in TS

(cherry picked from commit b1b74a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-scott oliver-scott oliver-scott approved these changes

@komaldabhi1509 komaldabhi1509 komaldabhi1509 approved these changes

@SamKompfner-HMCTS SamKompfner-HMCTS SamKompfner-HMCTS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaed-parkar @oliver-scott @komaldabhi1509 @SamKompfner-HMCTS