Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-11052 Fix for audio recording setting not updating in waiting room #2275

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Oct 18, 2024

Jira link

https://tools.hmcts.net/jira/browse/VIH-11052

Change description

Fixes an issue where audio recording is still shown as disabled in the waiting room after changing it to enabled on the booking.

  • Subscribe to the hearing details updated event, and update the conference when the event is received
  • Change the hearing details updated event to publish the conference object

Copy link

@oliver-scott oliver-scott marked this pull request as ready for review October 21, 2024 12:46
@oliver-scott oliver-scott requested review from a team as code owners October 21, 2024 12:46
Copy link
Contributor

@will-craig will-craig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@oliver-scott oliver-scott merged commit 181b0c9 into master Oct 21, 2024
8 checks passed
@oliver-scott oliver-scott deleted the bug/VIH-11052-audio-recording-not-updating branch October 21, 2024 15:11
oliver-scott added a commit that referenced this pull request Oct 21, 2024
#2275)

* Fetch conference when conference is updated

* Push conference object as part of HearingDetailsUpdated event

* Formatting

* Remove ConferenceDto

* Set conference from the hearing details updated message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants