VIH-11081 observers are connected with audio and video and device controls #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-scott
approved these changes
Oct 23, 2024
komaldabhi1509
approved these changes
Oct 24, 2024
shaed-parkar
force-pushed
the
feature/VIH-11081_observers_connect_as_normal
branch
from
13209be to
805f904
Compare
|
shaed-parkar
deleted the
feature/VIH-11081_observers_connect_as_normal
branch
shaed-parkar
added a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
VIH-11081
Change description
This pull request removes the "receive-only call" feature for participants. It also removes the await on the retrieve self test score to allow the user to continue quickly without being stuck waiting for the self test score operation to complete
Removal of "receive-only call" feature:
VideoWeb/VideoWeb/ClientApp/src/app/waiting-space/services/video-call.service.ts: Removed themakeReceiveOnlyCallmethod and associated logic.VideoWeb/VideoWeb/ClientApp/src/app/waiting-space/waiting-room-shared/waiting-room-base.component.ts: Removed the conditional logic formakeReceiveOnlyCallbased on participant roles.Refactoring role checks:
VideoWeb/VideoWeb/ClientApp/src/app/waiting-space/hearing-controls/hearing-controls-base.component.ts: Simplified role checks incanShowScreenShareButtonandcheckCameraAndMicrophonePresencemethods.Other changes:
VideoWeb/VideoWeb/ClientApp/src/app/shared/self-test/self-test.component.ts: Removed theawaitkeyword from theretrieveSelfTestScoremethod call.