VIH-11082 im behind feature flag #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaed-parkar
force-pushed
the
feature/VIH-11082_im_behind_feature_flag
branch
from
7c1c345 to
ff196af
Compare
komaldabhi1509
approved these changes
Nov 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
VIH-11082
Change description
This pull request introduces several changes to the
VideoWebproject, primarily focusing on the implementation of a new feature flag for instant messaging and various code refactoring for better readability and maintainability.Feature Flag Implementation:
instant-messagingto theFEATURE_FLAGSobject inlaunch-darkly.service.ts.CommandCentreMenuComponent,JohWaitingRoomComponent,JudgeWaitingRoomComponent, andParticipantWaitingRoomComponentto conditionally display the instant messaging feature.Code Refactoring:
WaitingRoomBaseDirectiveto include the newinstantMessagingEnabledproperty and its corresponding feature flag check.FEATURE_FLAGSin theCommandCentreMenuComponentto use the new feature flag.Additional BugFix Changes:
getCurrentLayoutmethod inhearing-layout.service.tsto ensure the conference object is not null before proceeding.