Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-11176 Replace usage of ForceGetConference #2319

Merged
merged 4 commits into from
Nov 29, 2024
Merged

VIH-11176 Replace usage of ForceGetConference #2319

merged 4 commits into from
Nov 29, 2024

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Nov 27, 2024 •
edited
Loading

Jira link

https://tools.hmcts.net/jira/browse/VIH-11176

Change description

Replace calls to ForceGetConference with GetConference for user-facing endpoints

@oliver-scott oliver-scott marked this pull request as ready for review November 28, 2024 11:52
@oliver-scott oliver-scott requested review from a team as code owners November 28, 2024 11:52
marcogagliardi
marcogagliardi approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@marcogagliardi marcogagliardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

shaed-parkar
shaed-parkar approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@shaed-parkar shaed-parkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oliver-scott oliver-scott merged commit 6eb9e65 into master Nov 29, 2024
10 of 11 checks passed
@oliver-scott oliver-scott deleted the VIH-11176-get-conference branch November 29, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komaldabhi1509 komaldabhi1509 komaldabhi1509 approved these changes

@shaed-parkar shaed-parkar shaed-parkar approved these changes

@marcogagliardi marcogagliardi marcogagliardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliver-scott @marcogagliardi @shaed-parkar @komaldabhi1509