Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-11193 AudioNotRequired scenario #2323

Merged
merged 1 commit into from
Dec 2, 2024
+13 −0
Merged

VIH-11193 AudioNotRequired scenario #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...b/ClientApp/src/app/waiting-space/judge-waiting-room/judge-waiting-room.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,6 +881,7 @@ describe('JudgeWaitingRoomComponent when conference exists', () => {
beforeEach(() => {
component.showVideo = true;
component.audioErrorRetryToast = null;
component.conference.audio_recording_required = true;
notificationToastrService.showAudioRecordingErrorWithRestart.and.returnValue(toast);
notificationToastrService.showAudioRecordingErrorWithRestart.calls.reset();
notificationToastrService.showAudioRecordingRestartSuccess.calls.reset();
Expand Down Expand Up @@ -954,6 +955,17 @@ describe('JudgeWaitingRoomComponent when conference exists', () => {
expect(notificationToastrService.showAudioRecordingErrorWithRestart).toHaveBeenCalledTimes(0);
});

it('when audio recording is not required on the hearing, do nothing', () => {
audioRecordingServiceSpy.wowzaAgent = null;
component.conference.audio_recording_required = false;
component.conference.status = ConferenceStatus.InSession;

component.verifyAudioRecordingStream();

expect(notificationToastrService.showAudioRecordingRestartFailure).toHaveBeenCalledTimes(0);
expect(notificationToastrService.showAudioRecordingErrorWithRestart).toHaveBeenCalledTimes(0);
});

describe('Multiple Hosts Audio Alert', () => {
it('When Audio Recording Alert is displayed, restart is actioned by another user and closed for the current user', () => {
// Arrange
Expand Down
1 change: 1 addition & 0 deletions ...deoWeb/ClientApp/src/app/waiting-space/judge-waiting-room/judge-waiting-room.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ export class JudgeWaitingRoomComponent extends WaitingRoomBaseDirective implemen
// Recording is not paused
// and the audio streaming agent cannot be validated, then show the alert
if (
this.conference.audio_recording_required &&
!this.continueWithNoRecording &&
this.showVideo &&
!this.audioErrorRetryToast &&
Expand Down