Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-11143 migrate event handling to effects and conference store #2343

Merged
merged 16 commits into from
Jan 6, 2025
Merged

VIH-11143 migrate event handling to effects and conference store #2343

merged 16 commits into from
Jan 6, 2025

Conversation

shaed-parkar
Copy link
Contributor

@shaed-parkar shaed-parkar commented Dec 17, 2024 •
edited
Loading

Jira link

VIH-11143

BUGFIX

Check the hearingDetailsUpdatedMessage belongs to the current conference

Refactoring to lessen the work in the waiting room component

  • migrate event handling to effects and conference store
  • Remove obsolete Allowed-Endpoints operation and models, it is already updated in the conferenceStore and switched to in a recent change. No need to make an additional API call anymore
  • Move toast notifications for endpoint changes into effects
  • Move the playHearingAlert sound into an effect
  • Re-introduced the binding to the mute attribute for video elements but this time to the show video property

@shaed-parkar shaed-parkar marked this pull request as ready for review December 17, 2024 20:34
@shaed-parkar shaed-parkar requested review from a team as code owners December 17, 2024 20:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shaed-parkar shaed-parkar merged commit c027db9 into master Jan 6, 2025
10 of 11 checks passed
@shaed-parkar shaed-parkar deleted the task/VIH-11143_migrate_to_ngrx_store branch January 6, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-scott oliver-scott oliver-scott approved these changes

@komaldabhi1509 komaldabhi1509 komaldabhi1509 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaed-parkar @oliver-scott @komaldabhi1509