Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-11274 apply host microphone preferences after joining a hearing in session #2367

Merged
merged 2 commits into from
Feb 5, 2025
Merged

VIH-11274 apply host microphone preferences after joining a hearing in session #2367

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb7453a
VIH-11274 apply host microphone preferemces after joining a hearing i…
shaed-parkar Feb 4, 2025
4793165
house keeping
shaed-parkar Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...eoWeb/ClientApp/src/app/waiting-space/hearing-controls/hearing-controls-base.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,16 @@ export abstract class HearingControlsBaseComponent implements OnInit, OnDestroy
this.isSpotlighted = loggedInParticipant.pexipInfo?.isSpotlighted;
});

this.conferenceStore
.select(ConferenceSelectors.getPexipConference)
.pipe(
takeUntil(this.destroyedSubject),
filter(x => !!x && x.started)
)
.subscribe(() => {
this.handleHearingCountdownComplete(this.conferenceId);
});

this.conferenceStore
.select(ConferenceSelectors.getParticipants)
.pipe(takeUntil(this.destroyedSubject))
Expand Down
8 changes: 4 additions & 4 deletions VideoWeb/VideoWeb/ClientApp/src/app/waiting-space/store/effects/notification.effects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class NotificationEffects {
]),
filter(
([action, activeConference, loggedInParticipant]) =>
action.conferenceId === activeConference.id && loggedInParticipant.role === Role.JudicialOfficeHolder
action.conferenceId === activeConference?.id && loggedInParticipant?.role === Role.JudicialOfficeHolder
),
tap(([action]) => {
if (action.status === ConferenceStatus.InSession) {
Expand All @@ -48,9 +48,9 @@ export class NotificationEffects {
]),
filter(
([action, activeConference, loggedInParticipant]) =>
action.conferenceId === activeConference.id &&
loggedInParticipant.hearingRole !== HearingRole.WITNESS &&
(loggedInParticipant.role === Role.Individual || loggedInParticipant.role === Role.Representative)
action.conferenceId === activeConference?.id &&
loggedInParticipant?.hearingRole !== HearingRole.WITNESS &&
(loggedInParticipant?.role === Role.Individual || loggedInParticipant?.role === Role.Representative)
),
tap(([action, activeConference, loggedInParticipant]) => {
let hasWitnessLink = false;
Expand Down