Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-11314 migrate start pause close actions #2398

Merged
merged 36 commits into from
Mar 24, 2025
Merged

VIH-11314 migrate start pause close actions #2398

merged 36 commits into from
Mar 24, 2025
+4,930 −5,615

Conversation

shaed-parkar
Copy link
Contributor

Jira link

VIH-11314

Change description

  • Continue to migrate actions to effects such as start, pause, end hearing
  • Remove unnecessary subscriptions in the waiting room component since the store is already being subscribed to
    • Move side effects in these handlers such as display notification for participant added into an effect

@shaed-parkar shaed-parkar requested review from a team as code owners March 14, 2025 11:05
will-craig
will-craig approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@will-craig will-craig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - can see you've put alot of work into this. Will need thoroughly test this

@shaed-parkar
Copy link
Contributor Author

Nice work - can see you've put alot of work into this. Will need thoroughly test this

Thanks, UI tests picked up a couple of issues and now they're all green. I've given a list of scenarios to re-test in the ticket

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shaed-parkar shaed-parkar merged commit 3f7ff05 into master Mar 24, 2025
12 checks passed
@shaed-parkar shaed-parkar deleted the feature/VIH-11314_migrate_start_pause_close_actions branch March 24, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-craig will-craig

@komaldabhi1509 komaldabhi1509

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shaed-parkar @will-craig @komaldabhi1509