Bugs fixed and Enhancement #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 2, 2013 10:50
2. Implement trident state for ES 3. Add unit-test with embedded ES server
…earch Conflicts: src/main/java/com/hmsonline/storm/elasticsearch/trident/ElasticSearchState.java
| @@ -72,12 +77,14 @@ public void createIndices(TridentElasticSearchMapper mapper, List<TridentTuple> | |||
| Map<String, Object> data = mapper.mapToData(tuple); | |||
| String parentId = mapper.mapToParentId(tuple); | |||
|
|
|||
| // TODO: this is not efficient. Creating indices should happen at | |||
There was a problem hiding this comment.
You can probably remove this code. We should assume that all indexes are created ahead of time.
There was a problem hiding this comment.
Sorry for late noticing. I have removed those stuff and also mark the methods in Mapper deprecated
…ping is existed before execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: we should remove all @deprecated stuff in the next release