Disallow nullable for questions

hnuti-brontosaurus · Mar 11, 2021 · 24f618a · 24f618a
1 parent f7bdb7c
commit 24f618a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Request/EventAttendee.php b/src/Request/EventAttendee.php
@@ -17,7 +17,7 @@ public function __construct(
 		string $phoneNumber,
 		string $emailAddress,
 		?string $note,
-		?array $questionAnswers,
+		array $questionAnswers,
 	) {
 		parent::__construct([
 			self::PARAM_QUERY => 'prihlaska',

diff --git a/src/Response/Event/Registration/RegistrationType.php b/src/Response/Event/Registration/RegistrationType.php
@@ -34,11 +34,11 @@ final class RegistrationType
 
 	/**
 	 * @param int $type
-	 * @param array|null $questions
+	 * @param array $questions
 	 * @param string|null $email
 	 * @param string|null $url
 	 */
-	private function __construct($type, array $questions = null, $email = null, $url = null)
+	private function __construct($type, array $questions, $email = null, $url = null)
 	{
 		if ( ! \in_array($type, [
 			self::TYPE_VIA_BRONTOWEB,
@@ -51,7 +51,7 @@ private function __construct($type, array $questions = null, $email = null, $url
 
 		$this->type = $type;
 
-		if ($type === self::TYPE_VIA_BRONTOWEB && $questions !== null && \count($questions) > 0) {
+		if ($type === self::TYPE_VIA_BRONTOWEB && \count($questions) > 0) {
 			$this->questions = \array_map(function ($question) {
 				return RegistrationQuestion::from($question);
 			}, $questions);
@@ -76,12 +76,12 @@ private function __construct($type, array $questions = null, $email = null, $url
 
 	/**
 	 * @param int $type
-	 * @param array|null $questions
+	 * @param array $questions
 	 * @param string|null $email
 	 * @param string|null $url
 	 * @return self
 	 */
-	public static function from($type, array $questions = null, $email = null, $url = null)
+	public static function from($type, array $questions, $email = null, $url = null)
 	{
 		return new self($type, $questions, $email, $url);
 	}