Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2092 Fix skill tester rating predictions #2098

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

wsbrenk
Copy link
Collaborator

@wsbrenk wsbrenk commented Jun 30, 2024

  1. changes proposed in this pull request:

    • fixes issue Skilltester[BUG] #2092
    • if not fixing an existing issue, comments explaining the purpose of the PR should be provided)
  2. src/main/resources/release_notes.md ...

  • has been updated
  • does not require update
  1. [Optional] suggested person to review this PR @tychobrailleur

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Jun 30, 2024

@tychobrailleur what is your opinion: Should we change version to 8.1? Would be a little work on release_notes and changelog.

@@ -187,30 +192,51 @@ public void setSpieler(Player player) {
repaint();
}

/**
* Initialize temporal player instance with combo box selections
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“temporal” : temporary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Jul 1, 2024

merge request #2094 will change ho version to 8.1 and initializes changelog and release_notes.
should be merged before this one.

# Conflicts:
#	src/main/resources/release_notes.md
@wsbrenk wsbrenk merged commit f1fe487 into ho-dev:release/8 Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants