Update: Enhanced loading times (#192)

hoangsonww · May 19, 2024 · d6a9939 · d6a9939
1 parent 9123f39
commit d6a9939
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 8 deletions.
diff --git a/MovieVerse-Frontend/js/movie-details.js b/MovieVerse-Frontend/js/movie-details.js
@@ -714,6 +714,8 @@ function getRatingDetails(rating) {
 }
 
 async function fetchMovieRatings(imdbId, tmdbMovieData) {
+    showSpinner();
+
     const apiKeys = [
         await getMovieCode2(),
         '58efe859',
@@ -729,7 +731,8 @@ async function fetchMovieRatings(imdbId, tmdbMovieData) {
             const response = await fetch(url);
             if (!response.ok) throw new Error('API limit reached or other error');
             return await response.json();
-        } catch (error) {
+        }
+        catch (error) {
             return null;
         }
     }
@@ -772,6 +775,7 @@ async function fetchMovieRatings(imdbId, tmdbMovieData) {
     }
 
     populateMovieDetails(tmdbMovieData, imdbRating, rtRating, metascore, awards, rated);
+    hideSpinner();
 }
 
 function updateBrowserURL(title) {
@@ -1515,4 +1519,4 @@ function applyTextColor(color) {
         .forEach(element => {
             element.style.color = color;
         });
-}
+}
diff --git a/...-Mobile/platforms/android/app/src/main/assets/www/MovieVerse-Frontend/js/movie-details.js b/...-Mobile/platforms/android/app/src/main/assets/www/MovieVerse-Frontend/js/movie-details.js
@@ -714,6 +714,8 @@ function getRatingDetails(rating) {
 }
 
 async function fetchMovieRatings(imdbId, tmdbMovieData) {
+    showSpinner();
+
     const apiKeys = [
         await getMovieCode2(),
         '58efe859',
@@ -729,7 +731,8 @@ async function fetchMovieRatings(imdbId, tmdbMovieData) {
             const response = await fetch(url);
             if (!response.ok) throw new Error('API limit reached or other error');
             return await response.json();
-        } catch (error) {
+        }
+        catch (error) {
             return null;
         }
     }
@@ -772,6 +775,7 @@ async function fetchMovieRatings(imdbId, tmdbMovieData) {
     }
 
     populateMovieDetails(tmdbMovieData, imdbRating, rtRating, metascore, awards, rated);
+    hideSpinner();
 }
 
 function updateBrowserURL(title) {
@@ -1515,4 +1519,4 @@ function applyTextColor(color) {
         .forEach(element => {
             element.style.color = color;
         });
-}
+}
diff --git a/MovieVerse-Mobile/platforms/ios/www/MovieVerse-Frontend/js/movie-details.js b/MovieVerse-Mobile/platforms/ios/www/MovieVerse-Frontend/js/movie-details.js
@@ -714,6 +714,8 @@ function getRatingDetails(rating) {
 }
 
 async function fetchMovieRatings(imdbId, tmdbMovieData) {
+    showSpinner();
+
     const apiKeys = [
         await getMovieCode2(),
         '58efe859',
@@ -729,7 +731,8 @@ async function fetchMovieRatings(imdbId, tmdbMovieData) {
             const response = await fetch(url);
             if (!response.ok) throw new Error('API limit reached or other error');
             return await response.json();
-        } catch (error) {
+        }
+        catch (error) {
             return null;
         }
     }
@@ -772,6 +775,7 @@ async function fetchMovieRatings(imdbId, tmdbMovieData) {
     }
 
     populateMovieDetails(tmdbMovieData, imdbRating, rtRating, metascore, awards, rated);
+    hideSpinner();
 }
 
 function updateBrowserURL(title) {
@@ -1515,4 +1519,4 @@ function applyTextColor(color) {
         .forEach(element => {
             element.style.color = color;
         });
-}
+}
diff --git a/MovieVerse-Mobile/www/MovieVerse-Frontend/js/movie-details.js b/MovieVerse-Mobile/www/MovieVerse-Frontend/js/movie-details.js
@@ -714,6 +714,8 @@ function getRatingDetails(rating) {
 }
 
 async function fetchMovieRatings(imdbId, tmdbMovieData) {
+    showSpinner();
+
     const apiKeys = [
         await getMovieCode2(),
         '58efe859',
@@ -729,7 +731,8 @@ async function fetchMovieRatings(imdbId, tmdbMovieData) {
             const response = await fetch(url);
             if (!response.ok) throw new Error('API limit reached or other error');
             return await response.json();
-        } catch (error) {
+        }
+        catch (error) {
             return null;
         }
     }
@@ -772,6 +775,7 @@ async function fetchMovieRatings(imdbId, tmdbMovieData) {
     }
 
     populateMovieDetails(tmdbMovieData, imdbRating, rtRating, metascore, awards, rated);
+    hideSpinner();
 }
 
 function updateBrowserURL(title) {
@@ -1515,4 +1519,4 @@ function applyTextColor(color) {
         .forEach(element => {
             element.style.color = color;
         });
-}
+}