Support node-18 builds with dist scripts #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxtomprice
force-pushed
the
node-18
branch
2 times, most recently
from
71e4dee
to
32f2bb5
Compare
hx-markterry
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support node-18
This bumps the .nvmrc and updates the package-lock.json with fresh data.
This also changes the code to allow consumers of this dependency to build using a
distscript instead of abuildscript.This has significant improvements on
npm installtimes under the latest versions of node and npm which automatically trigger that build script at install time.The existing version of the build script will continue to work as expected