-
Notifications
You must be signed in to change notification settings - Fork 56
Silence gradle deprecation warnings in v6 #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Declare dependencies with implementation, drop deprecated compilation Refactor dependencies from the two submodules into parent Upgrade com.moowork.node plugin to version 1.3.1 Upgrade node/npm to version 6.14.4 One deprecation warning remains about NpmSetupTask: Property 'args' is not annotated with an input or output annotation
I can barely spell gradle, I'm definitely not an expert, please check this carefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't test it aside from the fact that it compiles, but it looks good aside from having some potentially extra deps for all projects.
implementation 'com.google.code.findbugs:annotations:3.0.1' | ||
implementation 'com.google.guava:guava:18.0' | ||
implementation 'org.json:json:20140107' | ||
implementation 'com.beust:jcommander:1.48' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the added dependencies where they were before? Not all of the projects need to depend on every library.
Separately, if we want to declare the list of dependencies in just one place so we can make sure that each module is using the same version, we could do
ext.libs = [
guava: 'com.google.guava:guava:18.0',
...
]
in this file, and then in other build.gradle files, we could refer to that by saying implementation libs.guava
or something of that sort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make any change you like to this PR, it was just a first draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisinmtown since you were wondering about the GitHub etiquette elsewhere; the author tends to 'own' their own PRs in most projects I've worked on. I hope this doesn't dampen your enthusiasm, it's great to see these PRs coming from you! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks yeah I get it :) but gradle is black magic to me so I'm hoping maybe you'll make the fine adjustments and I'll learn from that.
Instead of fighting gradle, I'm focusing on extending this tool for HTTPS with as little disruption as possible to existing code.
Declare dependencies with implementation, drop deprecated compilation
Refactor dependencies from the two submodules into parent
Upgrade com.moowork.node plugin to version 1.3.1
Upgrade node/npm to version 6.14.4
One deprecation warning remains about NpmSetupTask:
Property 'args' is not annotated with an input or output annotation