This repository was archived by the owner on May 11, 2021. It is now read-only.
send HOLOCHAIN_WEBSOCKET_CONNECTED on reconnect events too - #15
Open
Connoropolous wants to merge 1 commit into
Open
send HOLOCHAIN_WEBSOCKET_CONNECTED on reconnect events too#15Connoropolous wants to merge 1 commit into
Connoropolous wants to merge 1 commit into
Conversation
Connoropolous
changed the title
Contributor
Author
|
@zippy I've added a PR description here. Can you see to it that this one gets followed up on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the conductor shuts down, then comes back online, I thought "why isn't it reconnecting", as I was watching the 'redux-dev-tools' action logger.
So this change just makes it so that instead of dispatching HOLOCHAIN_WEBSOCKET_CONNECTED only on the first connection to the websocket server, it will dispatch it on subsequent connections/reconnections too.