-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Widget.from_values #7033
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7033 +/- ##
==========================================
- Coverage 82.22% 81.77% -0.46%
==========================================
Files 326 326
Lines 48271 48293 +22
==========================================
- Hits 39691 39491 -200
- Misses 8580 8802 +222 ☔ View full report in Codecov by Sentry. |
This is a good start towards #7003; thanks! A few questions:
|
Honestly, while that's the logic for something like
Afaik, that isn't the case. It's no cheaper than doing the individual queries.
Will take a look. |
Hmm. I think I'd typically rather have a middle value mainly because choosing the lower or the upper seems arbitrary, and is also by definition an extreme value. Still, I guess it's not worth a lot of extra work. Plus using a midpoint could be problematic in some cases, e.g. when only a finite enumerable list of values is allowed, without values in between.
Drat. I saw some docs that implied they were performed together, but it didn't actually state that explicitly, and briefly clicking around in the source code suggests that it's decomposed into a separate call per agg function. Alas! You do need to run |
Implements #6071