Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dashboard in dev build #777

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Chapoly1305
Copy link

Fix for #776

Copy link
Contributor

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marcelveldt marcelveldt added the maintenance Code (quality) improvement or small enhancement which not a new feature label Jul 1, 2024
@marcelveldt
Copy link
Contributor

@Chapoly1305 can you have a look at the issues found by the linter ?

Use the installer provided on [Node.js website]. (https://nodejs.org/en/download/package-manager/current)
@Chapoly1305
Copy link
Author

@marcelveldt thanks for the notice. I adjusted the nodejs installer and use the official version, the previous in code was from a third-party website. Lint issue should also be fixed.

@MartinHjelmare MartinHjelmare changed the title #776 Enable Dashboard in Dev Build Enable Dashboard in Dev Build Jul 1, 2024
@MartinHjelmare MartinHjelmare changed the title Enable Dashboard in Dev Build Enable dashboard in dev build Jul 1, 2024
@marcelveldt
Copy link
Contributor

Still a lint issue found ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code (quality) improvement or small enhancement which not a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants