Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for test-net DCL #786

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Add flag for test-net DCL #786

merged 3 commits into from
Jul 3, 2024

Conversation

agners
Copy link
Collaborator

@agners agners commented Jul 2, 2024

Currently we fetch PAA certificates from the test-net DCL server by default. Often these are the same certificates as the production DCL, so this doesn't really have that much impact. However, those certs are really only required for development as certified devices will be present on the production DCL.

In the future we'll fetch more information from the DCL such as device update information etc. For these cases we really don't want production users to use test-net DCL by default.

This moves test-net DCL use behind a flag. By default this should be off.

Currently we fetch PAA certificates from the test-net DCL server by
default. Often these are the same certificates as the production DCL,
so this doesn't really have that much impact. However, those certs
are really only required for development as certified devices will be
present on the production DCL.

In the future we'll fetch more information from the DCL such as device
update information etc. For these cases we really don't want production
users to use test-net DCL by default.

This moves test-net DCL use behind a flag. By default this should be
off.
@agners agners added the new-feature New feature or request label Jul 2, 2024
@marcelveldt
Copy link
Contributor

marcelveldt commented Jul 2, 2024

I'd like this to be splitted; so an explicit flag for using test DCL for certificates and one for device updates.
For device updates, this is mainly a request from matter device developers and folks involved with matter/device development to be able to test the OTA from test DCL for a particular device(range), including myself actually ;-)

So I'm proposing we add a way to explicitly allow test DCL on a vendor or product id base.
That reduces the risk while still allowing developers (including us) to testdrive their updates.

For this PR, we could simply simplify it by making this boolean toggle only for the certificates downloads and then do the updates in a follow-up.

@agners
Copy link
Collaborator Author

agners commented Jul 2, 2024

I don't like splitting as there will be more things coming in the future, like checking certification status etc.

So that would add yet another flag. IMHO, it's not worth to have a "flag forest" just for test-net DCL things 🤷‍♂️

So I'm proposing we add a way to explicitly allow test DCL on a vendor or product id base.

This would add even more fields, just for testing. Even if we poll test-net DCL for device I am currently not interested, does it matter all that much? Internet is fast these days 🤷‍♂️

And if you are not developer, don't enable it.

That reduces the risk while still allowing developers (including us) to testdrive their updates.

Sure this will potentially show updates for devices we are not interested. But we don't auto-update, so just don't click that button no? 😅

Btw, on my desk:

  • Breakages from main net 1
  • Breakages from test net 0 (even though I did much more updates from here 🙈 )

@marcelveldt
Copy link
Contributor

OK, lets settle on a 2 phase step then:

One toggle enables test DCL but keep the explicit list for updates from test DCL.
I am just really worried that folks enable test DCL and then accidentally update to a test firmware on test DCL so an additional filter is really needed here.

@agners
Copy link
Collaborator Author

agners commented Jul 3, 2024

OK, lets settle on a 2 phase step then:

Ok, works for me.

One toggle enables test DCL but keep the explicit list for updates from test DCL.

I'll implement this part with the update PR then.

Copy link
Contributor

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agners agners merged commit f8fbbef into main Jul 3, 2024
4 checks passed
@agners agners deleted the add-option-for-test-net-dcl branch July 3, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants