-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag for test-net DCL #786
Conversation
Currently we fetch PAA certificates from the test-net DCL server by default. Often these are the same certificates as the production DCL, so this doesn't really have that much impact. However, those certs are really only required for development as certified devices will be present on the production DCL. In the future we'll fetch more information from the DCL such as device update information etc. For these cases we really don't want production users to use test-net DCL by default. This moves test-net DCL use behind a flag. By default this should be off.
I'd like this to be splitted; so an explicit flag for using test DCL for certificates and one for device updates. So I'm proposing we add a way to explicitly allow test DCL on a vendor or product id base. For this PR, we could simply simplify it by making this boolean toggle only for the certificates downloads and then do the updates in a follow-up. |
I don't like splitting as there will be more things coming in the future, like checking certification status etc. So that would add yet another flag. IMHO, it's not worth to have a "flag forest" just for test-net DCL things 🤷♂️
This would add even more fields, just for testing. Even if we poll test-net DCL for device I am currently not interested, does it matter all that much? Internet is fast these days 🤷♂️ And if you are not developer, don't enable it.
Sure this will potentially show updates for devices we are not interested. But we don't auto-update, so just don't click that button no? 😅 Btw, on my desk:
|
OK, lets settle on a 2 phase step then: One toggle enables test DCL but keep the explicit list for updates from test DCL. |
Ok, works for me.
I'll implement this part with the update PR then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Currently we fetch PAA certificates from the test-net DCL server by default. Often these are the same certificates as the production DCL, so this doesn't really have that much impact. However, those certs are really only required for development as certified devices will be present on the production DCL.
In the future we'll fetch more information from the DCL such as device update information etc. For these cases we really don't want production users to use test-net DCL by default.
This moves test-net DCL use behind a flag. By default this should be off.