Add 5 more health connect sensors #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
jpelgrom
reviewed
Nov 21, 2024
app/src/full/java/io/homeassistant/companion/android/sensors/HealthConnectSensorManager.kt
Outdated
Show resolved
Hide resolved
jpelgrom
approved these changes
Nov 22, 2024
alfieV
reviewed
Nov 23, 2024
Co-authored-by: alfie <[email protected]>
This was referenced Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#pendinig
Any other notes
these are the remaining sensors I plan to add as the rest needs more discussion or we should wait for a request before discussing
all sensors tested with health connect toolbox (side note: v1.9 seems to not insert records properly so rolled back to old build I had downloaded)