Use PEP 695 misc #117788
Merged
Use PEP 695 misc #117788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @Trekky12, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @ludeeus, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
frenck
approved these changes
May 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
cdce8p
added
smash
bajansen
pushed a commit
to bajansen/homeassistant
that referenced
this pull request
May 20, 2024
balloob
reviewed
May 21, 2024
| @@ -140,9 +140,6 @@ class UrlProtocolSchema(StrEnum): | |||
| sun_event = vol.All(vol.Lower, vol.Any(SUN_EVENT_SUNSET, SUN_EVENT_SUNRISE)) | |||
| port = vol.All(vol.Coerce(int), vol.Range(min=1, max=65535)) | |||
|
|
|||
| # typing typevar | |||
| _T = TypeVar("_T") | |||
There was a problem hiding this comment.
So this PR introduced a weird issue which I only noticed when testing Google Generative AI integation.
You have removed _T which breaks calling get_type_hints on ensure_list.
File "/home/vscode/.local/lib/python3.12/site-packages/voluptuous_openapi/__init__.py", line 106, in convert
v = convert(validator, custom_serializer=custom_serializer)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/vscode/.local/lib/python3.12/site-packages/voluptuous_openapi/__init__.py", line 236, in convert
schema = get_type_hints(schema).get(
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/typing.py", line 2281, in get_type_hints
hints[name] = _eval_type(value, globalns, localns)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/typing.py", line 414, in _eval_type
return t._evaluate(globalns, localns, recursive_guard)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/typing.py", line 924, in _evaluate
eval(self.__forward_code__, globalns, localns),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<string>", line 1, in <module>
NameError: name '_T' is not defined
This didn't fail in the tests because we don't serialize the full intent schemas there.
There was a problem hiding this comment.
❯ python3 -c 'from homeassistant.helpers.config_validation import ensure_list; from typing import get_type_hints; get_type_hints(ensure_list)'
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/local/lib/python3.12/typing.py", line 2281, in get_type_hints
hints[name] = _eval_type(value, globalns, localns)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/typing.py", line 414, in _eval_type
return t._evaluate(globalns, localns, recursive_guard)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/typing.py", line 924, in _evaluate
eval(self.__forward_code__, globalns, localns),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<string>", line 1, in <module>
NameError: name '_T' is not defined
There was a problem hiding this comment.
If I reinstate this line, everything works but mypy gives me this error:
homeassistant/helpers/config_validation.py:291: error: Name "_T" already defined on line 144 [no-redef]
Found 1 error in 1 file (checked 1 source file)
20 tasks
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Use PEP 695 in places missed during the first pass and small cleanups.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: