Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Local Calendar ics events import on calendar creation #117955

Merged

Conversation

raulcodes
Copy link
Contributor

Proposed change

Adds an optional step to the local calendar config flow that allows users to create a calendar with events populated from an ics file.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Config flow visual changes:
Screenshot 2024-05-22 at 10 16 42 PM
Screenshot 2024-05-22 at 10 17 02 PM

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: feature request discussion
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (local_calendar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of local_calendar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign local_calendar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Really appreciate your contributions here. WYDT about also doing url import? It can come in follow up PRs, but i thought it would be cool to extend to support that commonly requested use case also.

homeassistant/components/local_calendar/__init__.py Outdated Show resolved Hide resolved
tests/components/local_calendar/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 23, 2024 14:12
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@allenporter allenporter added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label May 23, 2024
@MartinHjelmare MartinHjelmare changed the title Local Calendar: Add ability to import ics events on calendar creation Add Local Calendar ics events import on calendar creation May 25, 2024
@frenck frenck force-pushed the import-ics-events-local-calendar branch from 98d94e7 to 6195d98 Compare July 7, 2024 20:42
@frenck frenck marked this pull request as ready for review July 7, 2024 20:42
@home-assistant home-assistant bot requested a review from allenporter July 7, 2024 20:42
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 7, 2024
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic, and very nice job with the testing. I have a couple minor comments.

homeassistant/components/local_calendar/helpers/ics.py Outdated Show resolved Hide resolved
homeassistant/components/local_calendar/helpers/ics.py Outdated Show resolved Hide resolved
tests/components/local_calendar/test_config_flow.py Outdated Show resolved Hide resolved
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as requesting changes

@home-assistant home-assistant bot marked this pull request as draft July 8, 2024 14:26
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Aug 12, 2024
@allenporter
Copy link
Contributor

This looks really close to being ready! Interested in making this happen? I think users would like it quite a bit.

@allenporter
Copy link
Contributor

allenporter commented Sep 29, 2024

This looks like the feedback was addressed and this is ready, nice. Marking as ready for review.

@allenporter allenporter marked this pull request as ready for review September 29, 2024 00:18
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out this PR and made some changes (that i requested below) but having trouble pushing. Edit: All good, got it working.

homeassistant/components/local_calendar/config_flow.py Outdated Show resolved Hide resolved
tests/components/local_calendar/test_config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/local_calendar/strings.json Outdated Show resolved Hide resolved
@allenporter
Copy link
Contributor

Updated UI
Screenshot 2024-09-28 at 5 41 19 PM

The radio but can be extended to support #126862

@allenporter allenporter added the smash Indicator this PR is close to finish for merging or closing label Sep 29, 2024
Co-authored-by: Paulus Schoutsen <[email protected]>
@allenporter
Copy link
Contributor

Thank you @raulcodes 👍🏼

@allenporter allenporter merged commit 5399e2b into home-assistant:dev Sep 29, 2024
29 of 30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@raulcodes raulcodes deleted the import-ics-events-local-calendar branch October 5, 2024 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-tests integration: local_calendar new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants