-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Local Calendar ics events import on calendar creation #117955
Add Local Calendar ics events import on calendar creation #117955
Conversation
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Really appreciate your contributions here. WYDT about also doing url import? It can come in follow up PRs, but i thought it would be cool to extend to support that commonly requested use case also.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
98d94e7
to
6195d98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic, and very nice job with the testing. I have a couple minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as requesting changes
This looks really close to being ready! Interested in making this happen? I think users would like it quite a bit. |
This looks like the feedback was addressed and this is ready, nice. Marking as ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out this PR and made some changes (that i requested below) but having trouble pushing. Edit: All good, got it working.
The radio but can be extended to support #126862 |
Co-authored-by: Paulus Schoutsen <[email protected]>
Thank you @raulcodes 👍🏼 |
Proposed change
Adds an optional step to the local calendar config flow that allows users to create a calendar with events populated from an ics file.
Type of change
Additional information
Config flow visual changes:
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: