-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aiovlc to 0.5.1 #126365
Bump aiovlc to 0.5.1 #126365
Conversation
Hey there @rodripf, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
mhhh ... why 🤔
|
The classifier was removed in the diff. Our license audit is too fragile to understand anything else. |
Fix for the license classifier -> MartinHjelmare/aiovlc#268 |
0.5.1 is released. |
both test failures are not related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* bump aiovlc to 0.5.0 * bump aiovlc to 0.5.1
@MartinHjelmare should we additionally set the timeout while instantiating the vlc class in the vlc_telnet component, or is the default timeout of 10s sufficient? What do you think? |
If we want to avoid the warning about slow update we could set the timeout to 9 seconds. |
Proposed change
diff: MartinHjelmare/aiovlc@v0.3.2...v0.5.1
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: