Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiovlc to 0.5.1 #126365

Merged

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Sep 20, 2024

Proposed change

diff: MartinHjelmare/aiovlc@v0.3.2...v0.5.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rodripf, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration (vlc_telnet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vlc_telnet can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vlc_telnet Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title bump aiovlc to 0.5.0 Bump aiovlc to 0.5.0 Sep 20, 2024
@mib1185
Copy link
Contributor Author

mib1185 commented Sep 20, 2024

We could not detect an OSI-approved license for [email protected]: Other/Proprietary License

mhhh ... why 🤔

$ pip show aiovlc
Name: aiovlc
Version: 0.5.0
Summary: Control VLC over telnet connection using asyncio
Home-page: https://github.com/MartinHjelmare/aiovlc
Author: Martin Hjelmare
Author-email: [email protected]
License: Apache Software License 2.0
Location: /home/vscode/.local/ha-venv/lib/python3.12/site-packages
Requires: rich, typer
Required-by: 
 pip-licenses -d -p aiovlc            
 Name    Version  License                    Description                                      
 aiovlc  0.5.0    Other/Proprietary License  Control VLC over telnet connection using asyncio 

@MartinHjelmare
Copy link
Member

The classifier was removed in the diff. Our license audit is too fragile to understand anything else.

@mib1185
Copy link
Contributor Author

mib1185 commented Sep 20, 2024

Fix for the license classifier -> MartinHjelmare/aiovlc#268

@mib1185 mib1185 marked this pull request as draft September 20, 2024 23:47
@MartinHjelmare
Copy link
Member

0.5.1 is released.

homeassistant/components/vlc_telnet/manifest.json Outdated Show resolved Hide resolved
requirements_all.txt Outdated Show resolved Hide resolved
requirements_test_all.txt Outdated Show resolved Hide resolved
@mib1185 mib1185 marked this pull request as ready for review September 21, 2024 08:47
@mib1185 mib1185 changed the title Bump aiovlc to 0.5.0 Bump aiovlc to 0.5.1 Sep 21, 2024
@mib1185
Copy link
Contributor Author

mib1185 commented Sep 21, 2024

both test failures are not related

@mib1185 mib1185 added this to the 2024.10.0b0 milestone Sep 21, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 52d349d into home-assistant:dev Sep 21, 2024
38 of 40 checks passed
JakeMartin-ICL pushed a commit to JakeMartin-ICL/home-assistant that referenced this pull request Sep 21, 2024
* bump aiovlc to 0.5.0

* bump aiovlc to 0.5.1
@mib1185 mib1185 deleted the vlc_telnet/bump-aiovlc-to-0.5.0 branch September 21, 2024 14:35
@mib1185
Copy link
Contributor Author

mib1185 commented Sep 21, 2024

@MartinHjelmare should we additionally set the timeout while instantiating the vlc class in the vlc_telnet component, or is the default timeout of 10s sufficient? What do you think?

@MartinHjelmare
Copy link
Member

If we want to avoid the warning about slow update we could set the timeout to 9 seconds.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants