Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing whitespace in Husqvarna Automower strings #126377

Closed

Conversation

Thomas55555
Copy link
Contributor

Breaking change

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should get caught by hassfest...
Are there times when we accept a trailing space?

@Thomas55555
Copy link
Contributor Author

I don't see a use-case for a entity name with a trailing space.

@epenet
Copy link
Contributor

epenet commented Sep 21, 2024

I don't see a use-case for a entity name with a trailing space.

My point exactly... that's why I think hassfest could be adjusted to catch these before they go in.

@epenet
Copy link
Contributor

epenet commented Sep 21, 2024

I don't see a use-case for a entity name with a trailing space.

My point exactly... that's why I think hassfest could be adjusted to catch these before they go in.

I think the check could be added here, if you feel like taking a look:

def translation_value_validator(value: Any) -> str:

@joostlek
Copy link
Member

Fixed n #126427

@joostlek joostlek closed this Sep 22, 2024
@Thomas55555 Thomas55555 deleted the fix-trailing-whitespace branch September 22, 2024 14:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants