Fix evohome HVAC modes for VisionPro Wifi systems #126378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: evohome
small-pr
MartinHjelmare
changed the title
…26397) The NumberMode should be BOX as per the entity description but due to the missing dataclass decorator was resolving to NumberMode.AUTO.
use 1s lower than scan interval
…ome-assistant#125805) * Add issue asking users to disable ESPHome assist_in_progress binary sensor * Include integration name in title and description * Add repair flow * Improve test coverage
zxdavb
requested review from
MartinHjelmare,
rytilahti,
bdraco,
allenporter,
OttoWinter,
jesserockz,
balloob and
synesthesiam
as code owners
|
closed as dirty commit in log |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
VisionPro Wifi systems are compatible with Honeywell (now Resideo) TCC, but have slightly different operating modes (e.g.
Offinstead ofHeatingOff). This issue was described in #32585 (which was closed when a related bug was addressed in #32604).Thus, these specific systems cannot be turned on/off via the UI or with the usual service calls.
NOTE: This fix adds a test for service calls (that exposed the bug, and confirms it has been resolved).
This new test has necessitated changes to conftest.py, and so some changes to other tests. It also adds another fixture, full of edge-cases.
I am in the process of adding yet further tests to evohome, and they also fail because of this issue (I have a fixture for VisionPro Wifi systems).
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: