Add Ituran integration

[shmuelzon]

Proposed change

This PR implements a new integration for the Ituran vehicle tracking service. It currently adds a device_tracker platform and, once merged, I will add a couple of sensors as well.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• Link to documentation pull request: Add Ituran integration home-assistant.io#35365

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[shmuelzon]

@joostlek thank you for the prompt review!

I've made the requested changes and responded to your questions. Please let me know if you'd like me to change anything else.

[shmuelzon]

Hey @joostlek, have you had a chance to look at my updates? Is there anything else you'd like me to change? Thanks!

[shmuelzon]

Hey @zweckj, thanks for your review. I changed some things according to your review but there were a few follow-up questions. Please let me know if you'd like me to change anything else

[shmuelzon]

@zweckj I finished addressing your latest review comments. Please let me know if there's anything else. Thanks in advance!

BTW - There's a test here that fails but I don't think it's related to any of my changes.

[shmuelzon]

@joostlek @zweckj If there's nothing else, please approve this pull request so I can prepare the following one for additional sensors. Thanks!

[shmuelzon]

@zweckj I fixed the tests as best as I could. Now might be a good time to state the I have no idea what I'm doing :)

Please let me know if there's anything else I can do to get this approved

[zweckj]

I think your tests need some more work. I'd suggest to take a look at some other integrations, e.g. lamarzocco, or palazetti for a shorter one

[shmuelzon]

I think your tests need some more work. I'd suggest to take a look at some other integrations, e.g. lamarzocco, or palazetti for a shorter one

I rewrote the tests, highly inspired by the palazzetti integration.

Thanks again for all the guidance, learning a lot (and more than I bargained for 😄)

[zweckj]

you'll need to add that to your docs PR because you'll need to reach Bronze with this PR

[zweckj]

those and otp are missing data_descriptions

[assafi-liveu]

I feel like the user step strings are descriptive enough as is. For the OTP I can add a description to wait for a text message or something

[zweckj]

you should be at a minimum able to group the tests that have side effects on otp usung parametrized tests (@pytest.mark.parametrize(), but probably even all failure tests with

    func = getattr(mock_ituran, "authenticate")
    func.side_effect = IturanApiError

[zweckj]

oh and i'd also at least a snapshot test for your platform, this can be done quickly with the helper await snapshot_platform(hass, entity_registry, snapshot, mock_config_entry.entry_id)