Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions to Music Assistant integration #129515

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

marcelveldt
Copy link
Member

@marcelveldt marcelveldt commented Oct 30, 2024

Proposed change

Add (custom) actions to the Music Assistant integration, e.g. to search media or have fine grained control over playing of media or announcements.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration (music_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of music_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign music_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@marcelveldt marcelveldt changed the title Add services to Music Assistant integration Add actions to Music Assistant integration Oct 30, 2024
@marcelveldt
Copy link
Member Author

I'll do tests in a separate PR as the foundation is missing to properly mock the Music Assistant Client

@marcelveldt marcelveldt marked this pull request as ready for review October 30, 2024 18:44
@marcelveldt marcelveldt added this to the 2024.11.0 milestone Oct 30, 2024
@MartinHjelmare
Copy link
Member

Why are we adding this after beta cut to beta?

@marcelveldt
Copy link
Member Author

Why are we adding this after beta cut to beta?

Because this is elementary - otherwise maybe better retract the base again and go for next month

@MartinHjelmare
Copy link
Member

Elementary isn't a criteria for adding things to the beta.

@MartinHjelmare MartinHjelmare removed this from the 2024.11.0 milestone Oct 31, 2024
@MartinHjelmare
Copy link
Member

I've removed this PR and the library bump from the milestone.

@marcelveldt
Copy link
Member Author

marcelveldt commented Oct 31, 2024

Base PR has been reverted from the 2024.11 branch so it wont be in the 2024.11 release and we can use the coming period to add the remaining functionality before 2024.12

@marcelveldt marcelveldt marked this pull request as draft October 31, 2024 09:23
@marcelveldt marcelveldt marked this pull request as ready for review October 31, 2024 10:13
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 8, 2024
@home-assistant home-assistant bot marked this pull request as draft November 19, 2024 14:00
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@marcelveldt marcelveldt marked this pull request as ready for review November 21, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants