-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actions to Music Assistant integration #129515
base: dev
Are you sure you want to change the base?
Conversation
Hey there @music-assistant, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I'll do tests in a separate PR as the foundation is missing to properly mock the Music Assistant Client |
Why are we adding this after beta cut to beta? |
Because this is elementary - otherwise maybe better retract the base again and go for next month |
Elementary isn't a criteria for adding things to the beta. |
I've removed this PR and the library bump from the milestone. |
Base PR has been reverted from the 2024.11 branch so it wont be in the 2024.11 release and we can use the coming period to add the remaining functionality before 2024.12 |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
17106bf
to
9fdd811
Compare
Proposed change
Add (custom) actions to the Music Assistant integration, e.g. to search media or have fine grained control over playing of media or announcements.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: