Suez water: fetch historical data in statistics #131166
Draft
+362
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @ooii, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
jb101010-2
force-pushed
the
feat_suez-statistics
branch
from
c9e0e6d
to
eabd939
Compare
8 tasks
jb101010-2
force-pushed
the
feat_suez-statistics
branch
from
eabd939
to
58d5f8d
Compare
jb101010-2
force-pushed
the
feat_suez-statistics
branch
from
58d5f8d
to
5f3206c
Compare
joostlek
requested changes
Nov 22, 2024
| with ( | ||
| patch("homeassistant.components.suez_water.PLATFORMS", [Platform.SENSOR]), | ||
| patch( | ||
| "homeassistant.components.suez_water.coordinator.SuezWaterCoordinator._update_statistics", |
There was a problem hiding this comment.
This should rather go in test_init as we have tests per platform and we don't want to assume you are using a coordinator
| _sum = 0 | ||
| for _k, stat in enumerate(stats[statistic_id]): | ||
| value = 500 | ||
| if statistic == "water_cost_statistics": |
There was a problem hiding this comment.
We should not have if statements in tests though
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fetch all historical provided by suez into statistics.
Suez water provide historical daily data of water consumption, these changes fetch all the available data and insert it into statistics to make it available in energy dashboard.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: