Skip to content

Fix Values for Recording mode and Infrared mode entities are not showing correctly#131487

Merged
frenck merged 3 commits intohome-assistant:devfrom
RaHehl:fix-unifiprotect-recording-infrared-view-only-labels
Nov 26, 2024
Merged

Fix Values for Recording mode and Infrared mode entities are not showing correctly#131487
frenck merged 3 commits intohome-assistant:devfrom
RaHehl:fix-unifiprotect-recording-infrared-view-only-labels

Conversation

@RaHehl
Copy link
Copy Markdown
Contributor

@RaHehl RaHehl commented Nov 24, 2024

Breaking change

Proposed change

Fixes #128269

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 25, 2024
@frenck frenck added this to the 2024.12.0b0 milestone Nov 25, 2024
@frenck frenck added the bugfix label Nov 26, 2024
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @RaHehl 👍

../Frenck

@frenck frenck merged commit 04b8a68 into home-assistant:dev Nov 26, 2024
@frenck frenck removed this from the 2024.12.0b0 milestone Nov 26, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 27, 2024
@RaHehl RaHehl deleted the fix-unifiprotect-recording-infrared-view-only-labels branch December 3, 2024 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cla-signed integration: unifiprotect Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Values for Recording mode and Infrared mode entities are not showing correctly

2 participants