Skip to content

Huawei LTE icon improvements#143342

Merged
thecode merged 2 commits intodevfrom
scop-huawei-lte-enb-icon
Apr 21, 2025
Merged

Huawei LTE icon improvements#143342
thecode merged 2 commits intodevfrom
scop-huawei-lte-enb-icon

Conversation

@scop
Copy link
Copy Markdown
Member

@scop scop commented Apr 20, 2025

Proposed change

eNodeB ID identifies the base station ~ antenna, so use the antenna icon for it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

This identifies the base station ~ tower, so use the tower icon for it.
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @fphammerle, mind taking a look at this pull request as it has been labeled with an integration (huawei_lte) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of huawei_lte can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign huawei_lte Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Comment thread homeassistant/components/huawei_lte/sensor.py Outdated
@scop scop changed the title Set icon for Huawei LTE eNodeB ID Huawei LTE icon improvements Apr 20, 2025
@thecode
Copy link
Copy Markdown
Member

thecode commented Apr 21, 2025

Thanks!

@thecode thecode merged commit 89a6bc4 into dev Apr 21, 2025
34 checks passed
@thecode thecode deleted the scop-huawei-lte-enb-icon branch April 21, 2025 15:09
tr4nt0r pushed a commit to tr4nt0r/ha-core that referenced this pull request Apr 22, 2025
* Set icon for Huawei LTE eNodeB ID

This identifies the base station ~ tower, so use the tower icon for it.

* Use antenna rather than (power) transmission tower across

home-assistant#143342 (comment)
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants