Relax typing on cached_property to accept subclasses

[bdraco]

Proposed change

This might need to be adjusted some more. That can happen here or in a future PR (this is new and we are still figuring out how its going to be fit in).

The goal was to get it working with #95315

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[cdce8p]

Does it work if we reuse the typeshed typing?
https://github.com/python/typeshed/blob/7d33060e6ae3ebe54462a891f0c566c97371915b/stdlib/functools.pyi#L196-L208

[bdraco]

Adjusted to match. Will wait for CI run and than pull out the entity changes if it passes

[cdce8p]

Adjusted to match. Will wait for CI run and than pull out the entity changes if it passes

Doesn't look like it, unfortunately. Let's just change _T to _T_co then and test it again.

[bdraco]

Adjusted to match. Will wait for CI run and than pull out the entity changes if it passes

Doesn't look like it, unfortunately. Let's just change _T to _T_co then and test it again.

👍
6eeaa51

[bdraco]

I think the current errors are ok as we want everything downstream to be a cached_property or explicitly have to add an ignore if they want to opt out

[cdce8p]

I think the current errors are ok as we want everything downstream to be a cached_property or explicitly have to add an ignore if they want to opt out

In that case, T can probably be changed back to invariant? I tested it locally and when I add backports.functools.cached_property downstream, it still seems to work.

[bdraco]

I think the current errors are ok as we want everything downstream to be a cached_property or explicitly have to add an ignore if they want to opt out

In that case, T can probably be changed back to invariant? I tested it locally and when I add backports.functools.cached_property downstream, it still seems to work.

Sounds good. I reverted the covar.

This is good because it means it should work 1:1 when we no longer have the backport and can use the cpython 3.12 version as it matches typeshed

[bdraco]

Thanks. Checking typeshed was a good call