-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for new integration igloohome #35784
base: next
Are you sure you want to change the base?
Conversation
- Added first markdown writeup for the integration.
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7e42c61
to
c45a4da
Compare
Does anyone know if this is something I can ignore? This PR looks to be correctly targetting the |
📝 Walkthrough📝 WalkthroughWalkthroughThe changes introduce a new documentation file for the igloohome integration with Home Assistant. This documentation details the integration's functionality, setup process, and prerequisites, including the need for an iglooaccess account. It provides a step-by-step guide for users to configure the integration using API credentials and categorizes the integration under sensors, with defined attributes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Home Assistant
participant igloodeveloper API
User->>Home Assistant: Sign in and input API credentials
Home Assistant->>igloodeveloper API: Request device battery levels
igloodeveloper API-->>Home Assistant: Return battery level updates
Home Assistant-->>User: Display device status
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Added first markdown writeup for the integration.
c45a4da
to
d384220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (3)
source/_integrations/igloohome.markdown (3)
20-22
: Consider adding more account detailsWhile the prerequisite is clear, it would be helpful to mention any specific account requirements (e.g., free vs paid account) or regional availability limitations if any exist.
26-33
: Fix formatting and typos in setup instructionsThere are several issues in the setup instructions:
- Typo: "crendentials" should be "credentials"
- Lists should be surrounded by blank lines
- Remove trailing spaces after "Home Assistant"
Once the account has been created: + - [Sign in](https://access.igloocompany.co/login). - Jump to [API access](https://access.igloocompany.co/api-access). - - Create a set of crendentials with the name `Home Assistant`. + - Create a set of credentials with the name `Home Assistant`. - Copy out the `Client ID` & `Client Secret`. - Add this integration to your Home Assistance instance. - Copy the `Client ID` & `Client Secret` to the respective text fields when prompted by the integration. - The integration will retrieve the devices under your account and update their last known battery level regularly.🧰 Tools
🪛 Markdownlint
29-29: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
27-27: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
33-33
: Consider adding a troubleshooting sectionTo improve user experience, consider adding a troubleshooting section that covers:
- Common setup issues
- API rate limits or connectivity problems
- Steps to take if device updates fail
- How to verify successful integration
Would you like me to provide a template for the troubleshooting section?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown
29-29: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
27-27: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)
18-18
: LGTM!
Good use of the {% term integration %}
template syntax and proper linking to the API documentation.
7-7
: Review the release version
The ha_release
value of "0.0.1" seems incorrect. For new integrations, this should typically match the upcoming Home Assistant release version.
- Corrected spelling mistake.
- Corrected spelling mistake. - Added blank line between list
…igloohome # Conflicts: # source/_integrations/igloohome.markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🧹 Outside diff range and nitpick comments (1)
source/_integrations/igloohome.markdown (1)
41-42
: Remove extra blank linesRemove the extra blank lines at the end of the file.
- -🧰 Tools
🪛 Markdownlint
41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines
(MD012, no-multiple-blanks)
42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines
(MD012, no-multiple-blanks)
38-38: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)
4-5
: Add lock platform to ha_platforms
The integration appears to support locks based on the API documentation, but only the sensor platform is listed.
ha_category:
- Sensor
+ - Lock
...
ha_platforms:
- sensor
+ - lock
Also applies to: 12-13
21-21
: Clarify account requirements
Please specify if the iglooaccess account is free or requires a subscription/payment.
- Change ha_release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
source/_integrations/igloohome.markdown (2)
32-33
: Consider adding expected outcome after setupThe setup instructions are clear, but consider adding a note about what users should expect to see in their Home Assistant dashboard after successful setup (e.g., where to find the battery sensors).
- Copy the `Client ID` & `Client Secret` to the respective text fields when prompted by the integration. - The integration will retrieve the devices under your account and update their last known battery level regularly. +- After successful setup, battery sensors for your devices will appear in your Home Assistant dashboard under the "Sensor" domain.
38-42
: Fix markdown formatting issuesThere are several formatting issues in this section that should be addressed:
+ - Battery entities: - Devices that have a battery level should be automatically recognized, and entities created. If devices are added post-integration, kindly reload the set of `Client Credentials`. - - - +🧰 Tools
🪛 Markdownlint
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
38-38: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines
(MD012, no-multiple-blanks)
42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines
(MD012, no-multiple-blanks)
38-38: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)
17-17
: LGTM!
The introduction clearly describes the integration's current functionality.
19-21
: LGTM!
Prerequisites are clearly stated with the necessary registration link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
source/_integrations/igloohome.markdown (3)
19-21
: Consider expanding prerequisites sectionTo help users prepare better, consider adding more details such as:
- Whether a free account is sufficient or if a paid subscription is required
- Any regional availability restrictions
- Minimum firmware requirements for compatible devices
35-42
: Fix markdown formatting issuesThere are some formatting issues that need to be addressed:
- Remove trailing space on line 40
- Remove extra blank lines at the end of the file
Apply this diff:
Once the correct `Client ID` & `Client Secret` has been provided: - Battery entities: - Devices that have a battery level should be automatically recognized, and entities created. If devices are added post-integration, kindly reload the set of `Client Credentials`. - - - +🧰 Tools
🪛 Markdownlint
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
38-38: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
42-42
: Consider adding a troubleshooting sectionTo enhance user experience, consider adding a troubleshooting section that covers:
- Common setup issues and their solutions
- API rate limits or timeout issues
- Steps to take when device updates fail
- How to resolve authentication problems
🧰 Tools
🪛 Markdownlint
42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint
source/_integrations/igloohome.markdown
40-40: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
41-41: Expected: 1; Actual: 2
Multiple consecutive blank lines
(MD012, no-multiple-blanks)
42-42: Expected: 1; Actual: 3
Multiple consecutive blank lines
(MD012, no-multiple-blanks)
38-38: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (1)
source/_integrations/igloohome.markdown (1)
23-33
: LGTM! Clear and well-structured setup instructions
The setup instructions are clear, concise, and provide a good step-by-step guide for users.
Proposed change
Added markdown documentation for new core integration 'igloohome'
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation