-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Reolink entities under 'Supported functionality' #35863
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Reolink integration in Home Assistant has been significantly restructured and updated. Key section headers have been modified for clarity, and new content has been added to enhance the description of various entities, including camera streams, binary sensors, number entities, and others. The updates provide detailed descriptions of functionalities, operational parameters, and user interaction options, improving the overall organization and comprehensiveness of the documentation. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant ReolinkIntegration
User->>HomeAssistant: Access Reolink integration documentation
HomeAssistant->>ReolinkIntegration: Retrieve updated documentation
ReolinkIntegration-->>HomeAssistant: Return structured documentation
HomeAssistant-->>User: Display updated documentation with new sections and details
Warning Rate limit exceeded@starkillerOG has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 52 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
source/_integrations/reolink.markdown (2)
257-261
: Fix grammar in update entity descriptionThe sentence has grammatical issues that affect clarity.
Apply this correction:
-Unfortunately this does not always shows the latest available firmware (also not in the Reolink applications). +Unfortunately, this does not always show the latest available firmware (also not in the Reolink applications).🧰 Tools
🪛 LanguageTool
[typographical] ~260-~260: Consider adding a comma after ‘Unfortunately’ for more clarity.
Context: ...t version" in the Reolink applications. Unfortunately this does not always shows the latest a...(RB_LY_COMMA)
[grammar] ~261-~261: After the auxiliary verb ‘do’, use the base form of a verb. Did you mean “show”?
Context: ...ons. Unfortunately this does not always shows the latest available firmware (also not...(AUXILIARY_DO_WITH_INCORRECT_VERB_FORM)
264-267
: Enhance media browser section structureConsider restructuring this section to make the steps and requirements clearer.
Consider this format:
-Depending on the support of the camera, the Reolink integration will provide a media browser through which recorded videos of the camera can be accessed. -In the sidebar, select "Media" > "Reolink" and select the **camera** of which you want to see recordings. Optionally, select if you want a high or low **resolution** stream and select the recording **date**. Here, all available video files of that day will be shown. -Recordings up to 1 month old can be viewed in Home Assistant. +The Reolink integration provides a media browser for accessing recorded videos (camera support required). To access recordings: + +1. Navigate to "Media" > "Reolink" in the sidebar +2. Select the desired **camera** +3. Choose the **resolution** stream (high/low) +4. Select the recording **date** + +**Note**: Recordings are available for viewing in Home Assistant for up to 1 month.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/reolink.markdown
(11 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/reolink.markdown
[typographical] ~260-~260: Consider adding a comma after ‘Unfortunately’ for more clarity.
Context: ...t version" in the Reolink applications. Unfortunately this does not always shows the latest a...
(RB_LY_COMMA)
[grammar] ~261-~261: After the auxiliary verb ‘do’, use the base form of a verb. Did you mean “show”?
Context: ...ons. Unfortunately this does not always shows the latest available firmware (also not...
(AUXILIARY_DO_WITH_INCORRECT_VERB_FORM)
🔇 Additional comments (1)
source/_integrations/reolink.markdown (1)
51-52
: LGTM! Documentation structure improvements
The reorganization of sections under "Supported functionality" improves readability and aligns with Home Assistant's integration quality scale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @starkillerOG 👍
../Frenck
Proposed change
Group Reolink entities under 'Supported functionality', more in line with https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/docs-supported-functions
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation