Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice docs updates #35885

Draft
wants to merge 9 commits into
base: current
Choose a base branch
from
Draft

Voice docs updates #35885

wants to merge 9 commits into from
+313 −71

Conversation

laupalombi
Copy link

@laupalombi laupalombi commented Nov 21, 2024 •
edited
Loading

Proposed change

Type of change

  • [ x] Spelling, grammar or other readability improvements (current branch).
  • [x ] Adjusted missing or incorrect information in the current documentation (current branch).
  • [ x] Removed stale or deprecated documentation.

Checklist

  • [x ] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [x ] The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Nov 21, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 11a62a2
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/673f9f211538f7000848e69b
😎 Deploy Preview https://deploy-preview-35885--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joostlek
Merge branch 'current' into voice-docs-updates
7fbeee0 
# Conflicts:
#	source/_integrations/lamarzocco.markdown
tetele
tetele reviewed Nov 21, 2024
View reviewed changes
source/voice_control/best_practices.markdown Outdated
- *Turn off the office lights*

So make sure your devices and entities are correctly assigned to areas, and your areas are correctly assigned to floors.
Learn how [here](https://www.home-assistant.io/voice_control/assign_areas_floors/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Learn how [here](https://www.home-assistant.io/voice_control/assign_areas_floors/).
Learn how [here](/voice_control/assign_areas_floors/).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not resolved yet, there are a lot more places where the full url is used and should be changed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are totally right, fixing it

@tetele tetele mentioned this pull request Nov 22, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaasnicolaas klaasnicolaas klaasnicolaas left review comments

@tetele tetele tetele left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laupalombi @tetele @klaasnicolaas @zweckj @joostlek