-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for igloohome lock/unlocking feature #37000
base: next
Are you sure you want to change the base?
Conversation
- Added troubleshooting steps
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the documentation for the igloohome integration, clarifying that bridge owners can lock, unlock, and open locks linked to a bridge. A new troubleshooting section titled "Unable to lock/unlock/open lock" has been added, detailing verification steps for users encountering issues with these functionalities, such as checking the bridge's power, internet connection, and Bluetooth range. Users are also advised to reload the config entry if they have changed the link between the bridge and the lock. Changes
Sequence DiagramsequenceDiagram
participant User
participant Bridge
participant Lock
participant HomeAssistant
User->>Bridge: Configure bridge
Bridge-->>HomeAssistant: Establish connection
User->>HomeAssistant: Request lock action
HomeAssistant->>Bridge: Transmit lock command
Bridge->>Lock: Execute lock/unlock/open
Lock-->>Bridge: Confirm action status
Bridge-->>HomeAssistant: Report action result
HomeAssistant-->>User: Provide action feedback
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(2 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/igloohome.markdown
83-83: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
84-84: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
86-86: null
Files should end with a single newline character
(MD047, single-trailing-newline)
🪛 GitHub Actions: home-assistant.io Test
source/_integrations/igloohome.markdown
[error] 85-85: Incorrect usage of the term: "bluetooth", use "Bluetooth" instead
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)
20-20
: LGTM! Clear documentation of the new feature.The added capability is well-documented and appropriately placed in the bridge owners section.
78-79
: LGTM! Helpful addition to authentication troubleshooting.The added guidance about checking API credential expiration enhances the troubleshooting section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/igloohome.markdown
[grammar] ~17-~17: Possible subject-verb agreement error.
Context: ...view). The features of this integration includes: - For [Bridge](https://www.igloohome....
(NNS_OF_SINGULAR_AGREEMENT)
🪛 Markdownlint (0.37.0)
source/_integrations/igloohome.markdown
83-83: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
84-84: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
86-86: null
Files should end with a single newline character
(MD047, single-trailing-newline)
🪛 GitHub Actions: home-assistant.io Test
source/_integrations/igloohome.markdown
[error] 85-85: Incorrect usage of the term: "bluetooth", use "Bluetooth" instead
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/igloohome.markdown (3)
20-20
: LGTM! Clear documentation of the new lock control feature.The new functionality for bridge owners is well-documented and clearly presented.
78-79
: LGTM! Helpful addition to authentication troubleshooting.The new point about API credential expiration adds valuable information for users troubleshooting authentication issues.
80-86
: Fix formatting issues in the troubleshooting section.The new troubleshooting section provides valuable information but has formatting issues that need to be addressed.
Please refer to the previous review comment for the detailed formatting fixes, including:
- Capitalizing "Bluetooth"
- Removing trailing spaces
- Adding consistent punctuation
- Adding newline at end of file
🧰 Tools
🪛 Markdownlint (0.37.0)
83-83: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
84-84: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
86-86: null
Files should end with a single newline character(MD047, single-trailing-newline)
🪛 GitHub Actions: home-assistant.io Test
[error] 85-85: Incorrect usage of the term: "bluetooth", use "Bluetooth" instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/igloohome.markdown (1)
86-86
: Add missing newline at end of file.Add a newline character at the end of the file to comply with markdown standards.
- If you've recently changed the link between the bridge and the lock, allow 1 hour for the integration to update itself, or reload the config entry to effect the change immediately. +
🧰 Tools
🪛 Markdownlint (0.37.0)
86-86: null
Files should end with a single newline character(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(2 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/igloohome.markdown
86-86: null
Files should end with a single newline character
(MD047, single-trailing-newline)
🔇 Additional comments (2)
source/_integrations/igloohome.markdown (2)
17-17
: Fix subject-verb agreement in features introduction.The subject "features" (plural) requires the plural form of the verb.
-The features of this integration includes: +The features of this integration include:
80-86
: Well-structured troubleshooting guidance!The new section provides clear, actionable steps for users experiencing issues with the lock/unlock functionality.
🧰 Tools
🪛 Markdownlint (0.37.0)
86-86: null
Files should end with a single newline character(MD047, single-trailing-newline)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @keithle888 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/igloohome.markdown (3)
17-17
: Enhanced Integration Description with New Feature Details
The updated introductory paragraph clearly explains that the integration now provides access via the igloodeveloper API along with the new functionality details. One minor nitpick: verify if the escaped parentheses in[smart access device\(s\)]
are necessary for proper markdown rendering; if not, consider removing them to improve readability.
78-79
: Consistent and Clear API Credentials Guidance
The added troubleshooting bullet point
- Ensure your API credentials have not expired or been revoked.
provides a valuable reminder for users. For improved clarity, consider slightly rephrasing it to:
- Ensure that your API credentials have not expired or been revoked.
This small change would maintain consistency with other troubleshooting statements.
80-86
: Comprehensive Troubleshooting Section for Lock/Unlock/Open Issues
The new troubleshooting section titled "Unable to lock/unlock/open lock" is well structured and clearly lays out the verification steps:
- The nested list under “Verify that the bridge is:” is correctly indented and easy to follow.
- The capitalization of “Bluetooth” on line 85 meets the Home Assistant style guidelines.
- The instruction to reload the config entry if the bridge-lock link is changed clearly communicates the required action.
A couple of minor suggestions:
- Ensure that there are no trailing spaces in the list items (as highlighted by markdownlint MD009).
- Verify that the file ends with a single newline character (to satisfy MD047).
Overall, this section effectively informs users how to troubleshoot the new lock/unlocking feature.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
86-86: Files should end with a single newline character
null(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/igloohome.markdown
(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/igloohome.markdown
86-86: Files should end with a single newline character
null
(MD047, single-trailing-newline)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/igloohome.markdown (1)
20-20
: Clear Addition of Lock/Unlock/Open Functionality
The new bullet point “Lock/Unlock/Open locks that are linked to a bridge.” succinctly communicates the added functionality for bridge owners. This directly aligns with the PR’s objective of documenting the new lock/unlocking feature.
Proposed change
Added documentation for update to igloohome integration with lock/unlocking feature.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit