-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add HomeWizard Plug-In battery as supported device in the HomeWizard integration #37036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HomeWizard Plug-In battery as supported device in the HomeWizard integration #37036
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the HomeWizard Energy integration documentation to include information about a new supported device called the "Plug-In Battery" with the model identifier Changes
The changes are straightforward and focused on expanding the documentation to include information about a new supported device within the HomeWizard Energy integration. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
source/_integrations/homewizard.markdown (1)
34-34
: Use language-neutral product URL.The link to the Plug-In Battery product page contains a Dutch language path segment (
/nl/
). For consistency with other device links and to ensure accessibility for all users, use the language-neutral URL.-[Plug-In Battery](https://www.homewizard.com/nl/plug-in-battery/): Sensors for power import/export, energy consumption, production, and state of charge (model: `HWE-BAT`). +[Plug-In Battery](https://www.homewizard.com/plug-in-battery/): Sensors for power import/export, energy consumption, production, and state of charge (model: `HWE-BAT`).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/homewizard.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/homewizard.markdown (1)
34-34
: Document WWHA certification status.Based on the PR objectives, this device is not WWHA certified. This information should be documented, possibly in the device description or in a new "Certification" section.
Let me check how certification status is documented for other integrations:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
For the WHHA markers, we are currently looking into how to differentiate on that (this is an issue on other places as well). Till we do, this PR is ready to go.
../Frenck
Just a heads-up, the parent PR has been merged but the label is not updated. This PR is still open. |
Proposed change
Add HomeWizard Plug-In Battery as supported device.
Note: This device is not certified for WWHA, I am unsure how/if we can mention that here.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
HWE-BAT