[en] Expand light_HassTurnOn and light_HassTurnOff with natural sentences #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViViDboarder
force-pushed
the
en-lights-llm
branch
from
78028a0
to
32c0ece
Compare
tetele
requested changes
Nov 5, 2024
There was a problem hiding this comment.
I agree with most proposals. The stuff I don't agree with are in comments below.
Two other things:
- This will have to be ported for
light_HassTurnOffas well - Let's settle on a style for optional parts of sentences:
[optional] partor[optional ]partand use that everywhere.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
ViViDboarder
force-pushed
the
en-lights-llm
branch
from
e336a18
to
e669eb3
Compare
ViViDboarder
changed the title
ViViDboarder
changed the title
|
Fixed tests and rebased. I also noticed a copy paste error that I corrected. |
tetele
approved these changes
Nov 18, 2024
tetele
force-pushed
the
en-lights-llm
branch
from
e669eb3
to
31fc907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used an LLM to generate a whole bunch of natural sounding sentences for the intent, cleaned them up by removing some that sounded not so natural, and then updated the sentences to get tests to pass. It also ended up suggesting some new expansions synonym expansions, so those are added to
_common.