-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SV] Light light changes #2473
base: main
Are you sure you want to change the base?
[SV] Light light changes #2473
Conversation
…ried again later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also some outcomment sentences and tests, we should add them or remove the comments.
Removed changes in README
I will add them once I figure out how I make them work. |
Hi, whats happening to this PR? It seem to cover a lot of what I was expecting when starting to use the PE. :) |
I am still on it. Though I don't find it easy. Building upon the English intents, Swedish is indeed a bit different. Hence having to look a bit into the German parts - and I don't talk German. Pretty much having to split the parts in Swedish that are different in turning on and off something. Like "tänd lampan", otherwise "slå på lampan" conflicts with "slå på damsugaren". So a bit difficult. Also I do find the docs to be somewhat lacking in how to accentuate areas, floors and stuff, than singular objects/entites. But I am getting there. |
Stuck at floors. Where do I add the floors else than in the fixtures? Should I use <> or {} ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
I have no idea what the conflict files are and how to fix them? |
This PR will be regarding making small changes to the intents (sentences) regarding light in Swedish. The aim is to add more sentences and make the intents even more fluid.