Open
Conversation
The CI workflow used a blanket `cancel-in-progress: true`, which makes sense for PR runs (collapse to the latest commit) but means pushes to `main` cancel each other when several PRs merge in quick succession. There is no shared state between CI runs that would justify either cancelling or serializing them — each run is independent — and we'd rather see every commit on `main` get a full check. Make the concurrency group unique per `run_id` for non-PR events so pushes to `main` neither cancel nor queue, while PRs keep the existing cancel-on-new-push behavior through the shared per-ref group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The CI workflow used a blanket
cancel-in-progress: true, which makes sense for PR runs (collapse to the latest commit) but means pushes tomaincancel each other when several PRs merge in quick succession. There is no shared state between CI runs that would justify either cancelling or serializing them — each run is independent — and we'd rather see every commit onmainget a full check.Make the concurrency group unique per
run_idfor non-PR events so pushes tomainneither cancel nor queue, while PRs keep the existing cancel-on-new-push behavior through the shared per-ref group.This mirrors the spirit of #6782, which addressed the same blanket cancellation in the builder workflow (though there the fix was to queue rather than run in parallel, since the builder publishes wheels).
Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed: