Open
Conversation
Move unconditional I/O helpers (FileExists, GetAllFileBytesAsync, WriteStreamAsync, DeleteFiles, BuildTempFilePath, EnsureDirectoryExists) into a new FileHandlerShared class. UploadStorageManager delegates to it and no longer holds a direct FileReaderWriter reference. FileHandlerShared is registered in DI alongside UploadStorageManager. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
I think this is worthy as a take 1 on splitting the upload/inbox mashup. It still retains a boolean IsDirectWrite in the class IncomingTransferStateItem but I think that's for a second round of cleanup and potentially unifying the PeerDriveIncomingFileUpdateService and PeerDriveIncomingTransferService |
Contributor
Author
|
The Windows errors seem to be unrelated to the code change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.