Skip to content

Conversation

erselbey
Copy link

@erselbey erselbey commented Mar 4, 2025

♻️ Current situation

Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).

💡 Proposed solution

Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?

⚙️ Release Notes

Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.

➕ Additional Information

If applicable, provide additional context in this section.

Testing

Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?

Reviewer Nudging

Where should the reviewer start? what is a good entry point?

@github-actions github-actions bot added the latest label Mar 4, 2025
@justjam2013
Copy link
Contributor

justjam2013 commented Jun 14, 2025

Please provide the requested information to explain why you believe that this change benefits the project, that you have considered and understood the repercussions of your change on other users, and provide a clear update path that current users can follow to maintain their installation running and accessible. I.e, no surprise changes.
Magic code changes will likely not be considered.

Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).

?

Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?

?

Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.

?

@justjam2013
Copy link
Contributor

Note that your PR conflicts with the following:

Homebridge requires full access to your local network to function correctly which can be achieved using the ```--net=host``` flag.

* `--net=host` - Shares host networking with container, **required**

Therefore applying your change would confuse the readers. Why does the document stress the requirement for --net=host, then use --net=bridge in the command example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants