Update how a plugin's author is determined to handle NPM schema change #2079
+54
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
NPM stopped returning the
maintainers
key from the registry when viewing a versioned package. Is this intentional? Nobody knows. I have a support ticket open with NPM since last Thursday, and the thread on GitHub Communities hasn't seen a response. This change has prevented the Homebridge UI from showing a plugin's author, as well as showing users that there is a Homebridge UI update from within Homebridge.💡 Proposed solution
Update how a plugin's author is determined: first, attempt to get it from the latest package from NPM (which is what is currently done). If it's not set there, get it from the top-level package metadata. Since getting it from the top-level package metadata can be expensive for packages with many versions, cache the author for 24 hours. This change will continue to work if NPM starts setting
maintainers
at the version level again, or if they never revert the change that stopped settingmaintainers
at the version level.