Added default values to Advanced Settings UI form and updated value change check #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per our conversation, you were unable to replicate the issue it is supposed to fix. "Works on my computer" is not an acceptable argument, so closing this pull request, until a working and verifiable solution is found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
See Unable to save on UI Advanced Settings form
💡 Proposed solution
Code changes for Unable to save on UI Advanced Settings form
➕ Additional Information
NOTE: This is an issue that will affect all the users that installed Homebridge UI prior to the beta-5.0.0 form validation changes and that accepted the default Settings & Advanced Settings values.