Skip to content

Commit

Permalink
Update to Synology Supplied NodeJS 20
Browse files Browse the repository at this point in the history
  • Loading branch information
NorthernMan54 committed Jan 3, 2024
1 parent 6d29ae1 commit 6f9941c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
#### Dependencies
This package will leverage the Synology supplied NodeJS v18 package.
This package will leverage the Synology supplied NodeJS v20 package.
#### Add the Homebridge Synology Package Source:
Expand Down
2 changes: 1 addition & 1 deletion INFO.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ silent_upgrade="no"
adminprotocol="http"
adminurl=""
adminport="8581"
install_dep_packages="Node.js_v18"
install_dep_packages="Node.js_v20"

displayname="Homebridge"
description="Homebridge on Synology DSM."
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
</p>

[![GitHub release](https://img.shields.io/github/release/homebridge/homebridge-syno-spk.svg)](https://github.com/homebridge/homebridge-syno-spk/releases/latest)
[![Build](https://github.com/homebridge/homebridge-syno-spk/workflows/Build/badge.svg)](https://github.com/homebridge/homebridge-syno-spk/actions)
[![Build and Publish](https://github.com/homebridge/homebridge-syno-spk/actions/workflows/main.yml/badge.svg)](https://github.com/homebridge/homebridge-syno-spk/actions/workflows/main.yml)
[![Donate](https://badgen.net/badge/donate/paypal/yellow)](https://paypal.me/oznu)

# Homebridge Package for Synology DSM
Expand All @@ -26,7 +26,7 @@ This package will deploy Homebridge and the Homebridge UI natively on your Synol

#### Dependencies

This package will leverage the Synology supplied NodeJS v18 package
This package will leverage the Synology supplied NodeJS v20 package

#### Add the Homebridge Synology Package Source:

Expand Down
5 changes: 4 additions & 1 deletion app/source.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ export HB_SERVICE_STORAGE_PATH="$(readlink -f /var/packages/homebridge/shares/ho
NODE_BIN_PATH="/var/packages/homebridge/target/app/bin"

# Use Synology supplied NodeJS v18 - https://github.com/homebridge/homebridge-syno-spk/issues/124
if [ -f /var/packages/Node.js_v18/target/usr/local/bin/node ]; then
if [ -f /var/packages/Node.js_v20/target/usr/local/bin/node ]; then
NODE_BIN_PATH="/var/packages/Node.js_v20/target/usr/local/bin:$NODE_BIN_PATH"
export HB_SERVICE_NODE_EXEC_PATH="/var/packages/Node.js_v20/target/usr/local/bin/node"
elif [ -f /var/packages/Node.js_v18/target/usr/local/bin/node ]; then
NODE_BIN_PATH="/var/packages/Node.js_v18/target/usr/local/bin:$NODE_BIN_PATH"
export HB_SERVICE_NODE_EXEC_PATH="/var/packages/Node.js_v18/target/usr/local/bin/node"
else
Expand Down

0 comments on commit 6f9941c

Please sign in to comment.