-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use new text-based bun lockfile #3846
chore: Use new text-based bun lockfile #3846
Conversation
d696723
to
4c28e6f
Compare
ab94405
to
9bca5a3
Compare
bun v1.1.39 is the minimum version to use text-based bun.lock file
9bca5a3
to
34ef8bf
Compare
I mistakenly formatted ci.yaml so I force pushed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3846 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 161 161
Lines 10240 10240
Branches 2926 2887 -39
=======================================
Hits 9351 9351
Misses 888 888
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn.lock
is necessary for using the np. You should not remove it.
Hi @ryoppippi Thank you for the PR. It's fine to use the text-based Bun lockfile. But as I commented, |
Hi! thank you for reviewing |
Looks like the latest version of |
@jbergstroem Thanks for your comment. |
looks like it was merged and even shipped 🚢! fast moves. |
Woooow awesome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @ryoppippi Looks good. I'll merge this now. Thank you! |
Yes!!! |
Hello!
Bun introduced new text-based lockfile
https://bun.sh/docs/install/lockfile#text-based-lockfile
Now we can see the diff of deps from this lockfile on Github! so I think we can delete the yarn.lock file
Also, I updated the bun's version for github actions to use this new lockfile