Schnarchnase advanced shopping lib

[Schnarchnase]

forum thread:
http://forums.heroesofnewerth.com/showthread.php?498015-Advanced-Shopping-Submission

[Schnarchnase]

Ty so far. Shall I do the changes immidiently or shall I wait for you?

You should be working on the submission version and not on the initial commit :)

[Kairus101]

I don't mind, you can do either, you will most likely find it easier to do all of it at once, once I've done a full pass over it :)

[Kairus101]

What I'd like is for all bots to have this automatically added to bots, with the default parameter, by replacing the current shopping. Bots can then change things about shopping lib via shopping.bCourierCare = 1 etc
This means removing the old shopping and replacing with your code - even crudely, I don't mind. Then it will be very, very close to approval, I'll just need to test it slightly more.

You'll need to go through all of your variables and make sure they have their type before the name, like nCost etc, S2 is VERY strict on this, and there are still quite a few that don't have them.

[Kairus101]

So like, a comment in behaviorLib which has all shopping removed, and instead just says, view advancedShopping.lua etc

[Schnarchnase]

There are a few major flaws in it :/

After testing some stuff:

1. Shared Consumables (Wards) --> Bots need to know wat to do, when they get unrequested items (General behavior for ward placement? Put it back into cour?)
2. Puzzlebox --> The workaround is pretty ugly and in general Cooldown-based items should be covered per API to prevent warnings and proper implementation (itemDef:IsInStock or itemDef:IsPurchaseble)
3. item ownership --> I'll track the current used courier slots (inventory), because i don't know the items ownership (bots can put other bots items into their own stash - API Request?).
4. Courier-loss : Items on the courier get lost, because bots can not pick up items on the ground (API Request)

(forgot 1 or 2 points though)

It seems to not work well in current matches, when people buy wards in courier / kill courier with bots items. This will happen frequently in human matches, so we should take a look for a better solution. While 2 and 3 are "minor" problems, 1 and 4 are crucial

[Kairus101]

I'm not concerned about the puzzlebox fix nor shared consumables, simple, we disable wards for now - because bots can't use em. Hopefully bots storing others items in their own stash should be fixed soon. Courier-loss is a pain, but it isn't your problem, let someone else do that, or do it yourself after this has been approved :)

[Schnarchnase]

Okay I'm done so far. Fixed a little issue while further testing.

Have fun :)

[Kairus101]

Don't worry about Mallocs comment, if need be I'll fork your branch when it is done and apply changes so it'd be a clean merge.
I have started testing and it is looking good so far, however I would like magmus, flint and witchslayer to override the current bots (it is either that or delete them, but I would rather the community have something to look at, and something for me to test with) So, fix all references to the now non-existent "advancedShoppingLib.lua" and replace the current bots with your example bots :)

[Schnarchnase]

Wow, something is really off since the last patch.

I didn't change anything at the purchase timings / courier behavior, but:
-bots buy before spawning in well at game start (first item may drop to stash) (did S2 change some loading stuff?)
-multiple cases of item migration (courier sending items to wrong bots (using couriers delivery(e)-spell) )
-game crashes after ~19 min of botgame (did anyone experience this while testing?)

[Kairus101]

All of that reams really out of whack, I've never had a crash, and items did seem to be working.. O.o

[Schnarchnase]

Ty for the fast response :)
I'll check my installation tomorrow. good night Sir :)

[Schnarchnase]

I have found the reason for crashing. It is an endless loop. Due to fail delivery someone else's item may result into our bots invetory/stash.
The bot will try to sell this item later into the game, which causes failure.
"void IUnitEntity:SellBySlot(nSlot)" has no success message. If we try to sell items from courier we re-enter the fill stash opeartion after selling...

A fix will be up shortly, just testing it now.

€: ... Still looking for a item delivery fix

[Kairus101]

Nice find :)