Feature/eslint config package

.eslintrc.js

@@ -0,0 +1,90 @@
+module.exports = {
+  root: true,
+  env: {
+    node: true,
+    es2021: true,
+    jest: true,
+    browser: true
+  },
+  plugins: [
+    'n',
+    '@typescript-eslint',
+    'unused-imports',
+    'sort-imports-es6-autofix'
+  ],
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/recommended-type-checked'
+  ],
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    ecmaVersion: 2021,
+    sourceType: 'module',
+    project: [
+      './tsconfig.json',
+      './packages/*/tsconfig.json'
+    ],
+    tsconfigRootDir: __dirname
+  },
+  rules: {
+    // Explicit offs
+    '@typescript-eslint/no-misused-promises': 'off',
+    '@typescript-eslint/no-unsafe-enum-comparison': 'off',
+    '@typescript-eslint/require-await': 'off',
+    '@typescript-eslint/restrict-template-expressions': 'off',
+    '@typescript-eslint/no-base-to-string': 'off',
+    'avoidEscape': 'off',
+    'camelcase': 'off',
+    'no-async-promise-executor': 'off',
+    'no-unreachable-loop': 'off',
+    'no-unused-vars': 'off',
+    'no-constant-condition': 'off',
+
+    // Explicit warns
+    'unused-imports/no-unused-imports': 'warn',
+    'sort-imports-es6-autofix/sort-imports-es6': [1, {
+      ignoreCase: false,
+      ignoreMemberSort: false,
+      memberSyntaxSortOrder: ['none', 'single', 'multiple', 'all']
+    }],
+
+    // Explicit errors
+    'array-callback-return': 'error',
+    'block-scoped-var': 'error',
+    'dot-notation': 'error',
+    'new-cap': [2, { 'properties': false }], // Used by ethers event filters
+    'no-empty': [2, { 'allowEmptyCatch': true }],
+    'no-new': 'error',
+    'prefer-const': [2, { 'destructuring': 'all' }],
+    'n/no-new-require': 'error',
+    'n/no-path-concat': 'error',
+    // Note: for @typescript-eslint/return-await', you must disable the base rule as it can report incorrect errors
+    'no-return-await': 'off',
+    '@typescript-eslint/return-await': 'error',
+
+    // Custom - These allow `any`. Remove over time as codebase is cleaned up
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-unsafe-assignment': 'off',
+    '@typescript-eslint/no-unsafe-argument': 'off',
+    '@typescript-eslint/no-unsafe-call': 'off',
+    '@typescript-eslint/no-unsafe-member-access': 'off',
+    '@typescript-eslint/no-unsafe-return': 'off',
+    '@typescript-eslint/no-redundant-type-constituents': 'off',
+
+    // Custom - Set to 1 or 2 over time as codebase is cleaned up. Possibly add options
+    '@typescript-eslint/prefer-nullish-coalescing': 'off',
+    '@typescript-eslint/no-unnecessary-type-assertion': 'off',
+    '@typescript-eslint/no-unused-vars': 'off',
+    '@typescript-eslint/no-floating-promises': 'off',
+    'no-else-return': 'off', // Could be a 1 but --fix does not correctly indent
+    // https://github.com/eslint/eslint/issues/3400
+    'no-lonely-if': 'off', // Could be a 1 but erroneously fixes nested items. Nesting is user error but still not worth the hassle
+    '@typescript-eslint/no-unnecessary-condition': 0 // Nice to have but need to clean up first
+  },
+  ignorePatterns: [
+    'node_modules',
+    'build',
+    'dist'
+  ]
+}

.github/workflows/debug.yml

@@ -1,4 +1,4 @@
-name: deploy
+name: Simple Github Action for Debugging Builds
 on:
   push:
     branches:
@@ -11,24 +11,27 @@ jobs:
     runs-on: ubuntu-latest
     defaults:
       run:
-        working-directory: ./packages/frontend
+        working-directory: .
     steps:
       - name: Checkout
         uses: actions/checkout@v2
 
       - name: Set up node
         uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 20
           registry-url: https://registry.npmjs.org
 
       - name: Install node dependencies
-        run: npm install --legacy-peer-deps
+        run: |
+          npm install -g pnpm@latest # required to build @eth-optimism packages
+          npm install -g only-allow@latest # required to build @eth-optimism packages
+          npm install
 
       - name: Build the frontend app
         env:
           PUBLIC_URL: .
           REACT_APP_NETWORK: goerli
           REACT_APP_IPFS_BUILD: true
-        run: npm run build
+        run: NODE_OPTIONS=--openssl-legacy-provider npm run build --workspace=@hop-protocol/frontend
 

.github/workflows/deploy.yml → .github/workflows/frontend.yml

@@ -1,4 +1,4 @@
-name: deploy
+name: Build and Deploy Hop Frontend UI
 on:
   push:
     branches:
@@ -37,15 +37,16 @@ jobs:
           echo "dnslink_subdomain=_dnslink.${GITHUB_REF#refs/heads/}" >> $GITHUB_OUTPUT
         fi
 
-  call-workflow1:
+  call-core-publish-workflow:
     name: Publish NPM Core Package If Necessary
     uses: ./.github/workflows/npm_publish_core.yml
     with:
       environment: production
     secrets:
       NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-  call-workflow2:
-    needs: call-workflow1
+
+  call-sdk-publish-workflow:
+    needs: call-core-publish-workflow
     name: Publish NPM SDK Package If Necessary
     uses: ./.github/workflows/npm_publish_sdk.yml
     with:
@@ -76,7 +77,7 @@ jobs:
     if: contains(github.ref, 'production') || contains(github.ref, 'preprod') || contains(github.ref, 'mainnet')
     name: Build and Deploy
     runs-on: ubuntu-latest
-    needs: [set_environment, call-workflow2]
+    needs: [set_environment, call-sdk-publish-workflow]
     outputs:
       hash: ${{ steps.upload.outputs.hash }}
     environment:
@@ -87,7 +88,7 @@ jobs:
       NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
     defaults:
       run:
-        working-directory: ./packages/frontend
+        working-directory: .
     steps:
       - name: Checkout
         uses: actions/checkout@v2
@@ -104,7 +105,9 @@ jobs:
           registry-url: https://registry.npmjs.org
 
       - name: Install node dependencies
-        run: npm install --legacy-peer-deps
+        run: |
+          npm install -g only-allow@latest pnpm@latest # required to build @eth-optimism packages
+          npm install
 
       - name: Build the frontend app
         env:
@@ -122,7 +125,7 @@ jobs:
           REACT_APP_DISABLED_ROUTES_NO_LIQUIDITY_WARNING_MESSAGE: ${{ secrets.REACT_APP_DISABLED_ROUTES_NO_LIQUIDITY_WARNING_MESSAGE }}
           REACT_APP_SHOW_BANNER_MESSAGE: ${{ secrets.REACT_APP_SHOW_BANNER_MESSAGE }}
           REACT_APP_BLOCKLIST_ENABLED: ${{ secrets.REACT_APP_BLOCKLIST_ENABLED }}
-        run: npm run build
+        run: NODE_OPTIONS=--openssl-legacy-provider npm run build --workspace=@hop-protocol/frontend
 
       - name: Write commit file
         uses: "DamianReeves/write-file-action@a432935930b2e351ec2d2792fc220717b656ec1c"