Call errback if sendCommand is called on a closed client#37
Open
fjakobs wants to merge 8 commits intohoratio-sans-serif:masterfrom
ajaxorg:2a09ff0e2977c29d5034d714a3838057458fd704
Open
Call errback if sendCommand is called on a closed client#37fjakobs wants to merge 8 commits intohoratio-sans-serif:masterfrom ajaxorg:2a09ff0e2977c29d5034d714a3838057458fd704
fjakobs wants to merge 8 commits intohoratio-sans-serif:masterfrom
ajaxorg:2a09ff0e2977c29d5034d714a3838057458fd704
Conversation
could skip commands if the stream is not readable
Without that the callback is never called, which break the control flow of the calling code.
horatio-sans-serif
force-pushed
the
master
branch
from
256c162 to
a773ce9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
http://github.com/ajaxorg/redis-node-client/commit/2a09ff0e2977c29d5034d714a3838057458fd704
This fix is critical since otherwise the callback is never called, which can break the control flow of the calling code. Please pull.
Thanks,
Fabian